guozhangwang commented on a change in pull request #9676:
URL: https://github.com/apache/kafka/pull/9676#discussion_r535691107
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1219,6 +1219,9 @@ class Log(@volatile private var _dir: File,
appendInfo.logAppendTime = duplicate.timestamp
appendInfo.logStartOffset = logStartOffset
case None =>
+ if (logDirFailureChannel.logDirIsOffline(parentDir)) {
+ throw new KafkaStorageException(s"The log dir $parentDir has
failed.");
Review comment:
Maybe we can leave a more informative error message here? Sth like "...
dir has failed due to a previous IO exception", just indicating it is not
failed because of the current calling trace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
