[GitHub] [kafka] hachikuji edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-16 Thread GitBox 


hachikuji edited a comment on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728383115


   Posting allocation flame graphs from the producer before and after this 
patch:
   
   ![Screen Shot 2020-11-16 at 5 26 56 
PM](https://user-images.githubusercontent.com/12502538/99328506-11ad2300-2831-11eb-806e-2fee6cce82a4.png)
   ![Screen Shot 2020-11-16 at 5 27 25 
PM](https://user-images.githubusercontent.com/12502538/99328510-140f7d00-2831-11eb-9d08-06f9538e5ade.png)
   
   So we succeeded in getting rid of the extra allocations in the network layer!
   
   I generated these graphs using the producer performance test writing to a 
topic with 10 partitions on a cluster with a single broker.
   ```
   > bin/kafka-producer-perf-test.sh --topic foo --num-records 25000 
--throughput -1  --record-size 256 --producer-props 
bootstrap.servers=localhost:9092
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] hachikuji edited a comment on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-16 Thread GitBox 


hachikuji edited a comment on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728383115


   Posting allocation flame graphs from the producer before and after this 
patch:
   
   ![Screen Shot 2020-11-16 at 3 02 42 
PM](https://user-images.githubusercontent.com/12502538/99318608-def92f80-281c-11eb-9dbd-9c75d2093fff.png)
   
   ![Screen Shot 2020-11-16 at 3 03 02 
PM](https://user-images.githubusercontent.com/12502538/99318616-e15b8980-281c-11eb-9024-c6cbb6c22230.png)
   
   So we succeeded in getting rid of the extra allocations in the network layer!
   
   I generated these graphs using the producer performance test writing to a 
topic with 10 partitions on a cluster with a single broker.
   ```
   > bin/kafka-producer-perf-test.sh --topic foo --num-records 25000 
--throughput -1  --record-size 256 --producer-props 
bootstrap.servers=localhost:9092
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org