[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats

2023-04-24 Thread via GitHub


hudeqi commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1520098448

   > @hudeqi Thanks for the PR and KIP. The KIP has to be discussed and voted 
by the community. See the process section in 
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
   > 
   > Also a previous KIP had similar goals: 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=148642648
   
   Sorry, I didn't notice that KIP mentioned this issue before. I read the 
previous KIP discussion, and it seems that there is no conclusion, so how to 
deal with this issue next?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats

2023-04-22 Thread via GitHub


hudeqi commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1518936086

   > > Does this PR need a KIP process? Anyone take a look?
   > 
   > Metrics are part of the public api. Changing or adding metrics require a 
KIP.
   
   Hi, thanks your reply, the KIP is 
[here](https://cwiki.apache.org/confluence/x/LQs0Dw).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats

2023-04-17 Thread via GitHub


hudeqi commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1512389741

   Does this PR need a KIP process? Anyone take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org