[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1593332941 > Also, @hudeqi please don't use force pushes because it makes it impossible to go back to previous commits which sometimes needed in reviews to get the proper context. When we merge a PR it gets squashed together into a single commit, so there is no need to force push. I see. Thank you for reminding! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1591024699 Hi, is there any suggestion and must do for this PR now? @dajac @satishd @divijvaidya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1582994469 @viktorsomogyi hi, this minor pr is also about replica fetcher thread, please help to review, thanks! Seems @dajac have no time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1569896940 hi, is this pr ready to merge? @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1551304423 Hi, do you have time to help review this? @dajac @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1548893409 Does anyone have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org