[GitHub] [kafka] ijuma commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-29 Thread GitBox 


ijuma commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r641965516



##
File path: build.gradle
##
@@ -449,6 +449,14 @@ subprojects {
 }
   }
 
+  // remove test output from Test, IntegrationTest and UnitTest

Review comment:
   I would say "remove test output from all test types" so that this 
comment doesn't go stale if we add more test types.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-28 Thread GitBox 


ijuma commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r641757745



##
File path: build.gradle
##
@@ -380,6 +380,15 @@ subprojects {
 }
   }
 
+  cleanTest {
+subprojects.each {
+  delete "${it.buildDir}/test-results/unitTest"
+  delete "${it.buildDir}/reports/tests/unitTest"
+  delete "${it.buildDir}/test-results/integrationTest"
+  delete "${it.buildDir}/reports/tests/integrationTest"
+}
+  }
+

Review comment:
   How do we know that the hardcoded directories here are all correct? Is 
there a way to get that data from gradle instead of hardcoding?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-17 Thread GitBox 


ijuma commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r633089109



##
File path: build.gradle
##
@@ -380,6 +380,15 @@ subprojects {
 }
   }
 
+  cleanTest {
+subprojects.each {
+  delete "${it.buildDir}/test-results/unitTest"
+  delete "${it.buildDir}/reports/tests/unitTest"
+  delete "${it.buildDir}/test-results/integrationTest"
+  delete "${it.buildDir}/reports/tests/integrationTest"
+}
+  }
+

Review comment:
   Is it useful for unit and integration test to use separate output dirs? 
Or should they all write to the same output dir as the tests command?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-16 Thread GitBox 


ijuma commented on a change in pull request #10585:
URL: https://github.com/apache/kafka/pull/10585#discussion_r633089109



##
File path: build.gradle
##
@@ -380,6 +380,15 @@ subprojects {
 }
   }
 
+  cleanTest {
+subprojects.each {
+  delete "${it.buildDir}/test-results/unitTest"
+  delete "${it.buildDir}/reports/tests/unitTest"
+  delete "${it.buildDir}/test-results/integrationTest"
+  delete "${it.buildDir}/reports/tests/integrationTest"
+}
+  }
+

Review comment:
   Is it useful for unit and integration test to use separate output dirs? 
Or should they all write to the same output dir as the tests command?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org