[GitHub] [kafka] joobisb commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on code in PR #13862: URL: https://github.com/apache/kafka/pull/13862#discussion_r1245268151 ## docs/quickstart.html: ## @@ -154,9 +154,9 @@ By default, each line you enter will result in a separate event being written to the topic. -$ bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 -This is my first event -This is my second event +$ bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 +$ This is my first event +$ This is my second event Review Comment: resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] joobisb commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on code in PR #13862: URL: https://github.com/apache/kafka/pull/13862#discussion_r1245058126 ## docs/quickstart.html: ## @@ -154,9 +154,9 @@ By default, each line you enter will result in a separate event being written to the topic. -$ bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 -This is my first event -This is my second event +$ bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server localhost:9092 +$ This is my first event +$ This is my second event Review Comment: will update these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] joobisb commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1245057900
##
docs/quickstart.html:
##
@@ -32,7 +32,7 @@
the latest Kafka release and extract it:
-$ tar -xzf
kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz
+$ tar -xzf
kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz
Review Comment:
https://github.com/apache/kafka/assets/13068144/e4285029-5a1c-4002-8ed6-f8a95c97e2a0;>
If I remove the `language-bash` class from `` it will lose the
associated properties as shown in the first image above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] joobisb commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1232988532
##
docs/streams/quickstart.html:
##
@@ -91,8 +91,8 @@ Step
https://www.apache.org/dyn/closer.cgi?path=/kafka/{{fullDotVersion}}/kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz;
title="Kafka downloads">Download the {{fullDotVersion}} release and un-tar
it.
Note that there are multiple downloadable Scala versions and we choose to use
the recommended version ({{scalaVersion}}) here:
- tar -xzf
kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz
- cd kafka_{{scalaVersion}}-{{fullDotVersion}}
+ $ tar -xzf
kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz
Review Comment:
right will remove those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
