[GitHub] [kafka] machi1990 commented on pull request #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

2023-06-27 Thread via GitHub


machi1990 commented on PR #13903:
URL: https://github.com/apache/kafka/pull/13903#issuecomment-1610089280

   Thank you @divijvaidya 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] machi1990 commented on pull request #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

2023-06-22 Thread via GitHub


machi1990 commented on PR #13903:
URL: https://github.com/apache/kafka/pull/13903#issuecomment-1602701557

   > Thank you for the change. We had an automated open PR #13743 for it for 
quite some time now. 
   
   Right, I wasn't aware of that PR. I should have checked before opening a 
similar one. 
   
   > Can you please explain how did you test this change?
   
   I am following the guide 
https://github.com/apache/kafka/blob/50c05cea8e9f24ebb88e342d3ba5d6dc062c09c5/tests/README.md#running-tests-using-docker
 
   
   I opened a PR after running a few specific tests and they were passing. 
   Currently I am running the whole test suite - this takes time, I'll report 
back once it finishes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org