[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

[GitBox]

mimaison commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-802792953


   Actually the fix is in 2.8 and above. It was made in 
https://github.com/apache/kafka/commit/cf202cb6acf38c64a3e8b9e541673a12ee55eaaa


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

[GitBox]

mimaison commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-797420022


   @askldjd Good catch, you're right it looks like this was only merged into 
2.4. I've reopened 
[KAFKA-10160](https://issues.apache.org/jira/browse/KAFKA-10160).
   Let's see if @satishbellapu has time to open a PR in the next few days. 
Otherwise I'll port this change next week



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

[GitBox]

mimaison commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-659272353


   Test failure is unrelated:
   - 
org.apache.kafka.streams.integration.BranchedMultiLevelRepartitionConnectedTopologyTest.testTopologyBuild



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

[GitBox]

mimaison commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-657451241


   ok to test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

[GitBox]

mimaison commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-653745978


   Thanks @satishbellapu for the update, it looks good. Can we add a test too?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

[GitBox]

mimaison commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-651658489


   @satishbellapu I'll try to take a look Thursday or Friday



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org