[GitHub] [kafka] mjsax commented on pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates
mjsax commented on pull request #8637: URL: https://github.com/apache/kafka/pull/8637#issuecomment-631803677 Seems you agree to my last comment: https://github.com/apache/kafka/pull/8504#issuecomment-631757206 I think it's best to close this PR and also the ticker (either as "not a problem" or "won't fix")? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates
mjsax commented on pull request #8637: URL: https://github.com/apache/kafka/pull/8637#issuecomment-628315503 @bbejeck Wondering if there are any backward incompatibility concerns? Can you explain why this change is safe? For #8504 there would be an exception before and thus it was broken and no compatibility concern raises. Not 100% sure about this PR though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org