[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-30 Thread GitBox 


mjsax commented on pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#issuecomment-701582027


   Thanks for the fix @JoelWee! Merged to `trunk`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-26 Thread GitBox 


mjsax commented on pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#issuecomment-681138143


   Retest this please.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox 


mjsax commented on pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455951


   @ableegoldman Can you help to review?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-08-21 Thread GitBox 


mjsax commented on pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455265


   Thanks for the PR @JoelWee -- Not exactly sure what NPE test you have in 
mind, but feel free to add a new test class 
`src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessorTest.java`
 if required.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org