[GitHub] [kafka] mjsax commented on pull request #9513: MINOR: improve `null` checks for headers

2020-10-29 Thread GitBox 


mjsax commented on pull request #9513:
URL: https://github.com/apache/kafka/pull/9513#issuecomment-719085653


   > However, it may be overkill since users don't create ConsumerRecord.
   
   Yeah, I tend to agree. Would not hurt to add it, but should not be strictly 
necessary. Will merge this as-is.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9513: MINOR: improve `null` checks for headers

2020-10-28 Thread GitBox 


mjsax commented on pull request #9513:
URL: https://github.com/apache/kafka/pull/9513#issuecomment-718125704


   @chia7712 Good call about `ConnectHeaders`. I am not sure what we would need 
to change in `ConsumerRecord` though? Can you elaborate?
   
   @showuon: what PR are you talking about?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org