[GitHub] [kafka] mumrah commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
mumrah commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r630302538
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+api project(':clients')
+implementation libs.slf4jApi
+
+testImplementation project(':clients')
+testImplementation project(':clients').sourceSets.test.output
+testImplementation libs.junitJupiter
+testImplementation libs.mockitoCore
+
+testRuntimeOnly libs.slf4jlog4j
+ }
+
+ task createVersionFile(dependsOn: determineCommitId) {
+ext.receiptFile = file("$buildDir/kafka/$buildVersionFileName")
+outputs.file receiptFile
+outputs.upToDateWhen { false }
+doLast {
+ def data = [
+ commitId: commitId,
+ version: version,
+ ]
+
+ receiptFile.parentFile.mkdirs()
+ def content = data.entrySet().collect { "$it.key=$it.value"
}.sort().join("\n")
+ receiptFile.setText(content, "ISO-8859-1")
+}
+ }
+
+ sourceSets {
+main {
+ java {
Review comment:
Are we only going to allow Java sources in this new module? (I think
that's probably a good idea)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] mumrah commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.
mumrah commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r630302538
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+api project(':clients')
+implementation libs.slf4jApi
+
+testImplementation project(':clients')
+testImplementation project(':clients').sourceSets.test.output
+testImplementation libs.junitJupiter
+testImplementation libs.mockitoCore
+
+testRuntimeOnly libs.slf4jlog4j
+ }
+
+ task createVersionFile(dependsOn: determineCommitId) {
+ext.receiptFile = file("$buildDir/kafka/$buildVersionFileName")
+outputs.file receiptFile
+outputs.upToDateWhen { false }
+doLast {
+ def data = [
+ commitId: commitId,
+ version: version,
+ ]
+
+ receiptFile.parentFile.mkdirs()
+ def content = data.entrySet().collect { "$it.key=$it.value"
}.sort().join("\n")
+ receiptFile.setText(content, "ISO-8859-1")
+}
+ }
+
+ sourceSets {
+main {
+ java {
Review comment:
Are we only going to allow Java sources in this new module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
