[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-650247166 Huge thanks to all reviewers and committers for providing valuable comments and testing results This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-650209463 @mimaison If the one failed test is not relevant, are we ready to merge, or anything I can do? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649827931 seems unrelated test failed: ``` kafka.api.PlaintextConsumerTest > testLowMaxFetchSizeForRequestAndPartition FAILED ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649747116 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649744933 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649744836 unrelated test failures: ``` kafka.api.SaslGssapiSslEndToEndAuthorizationTest > testProduceConsumeWithWildcardAcls FAILED org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest > testReplication FAILED (though in the same file that got changed, but testReplication is not involved this PR) kafka.api.PlaintextConsumerTest > testLowMaxFetchSizeForRequestAndPartition FAILED org.apache.kafka.streams.integration.EosIntegrationTest > shouldNotViolateEosIfOneTaskFailsWithState[exactly_once] FAILED ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649599205 @mimaison thanks so much for your fast response :) I have addressed your above 3 comments and please take the final review pass This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649092864 bump for attention @mimaison ^ given that https://issues.apache.org/jira/browse/KAFKA-9076 is slipped to the next release (2.7.0) and some people may be already testing/using this feature, I would hope if it is possible to revisit this PR soon so that it can formally part of Kafka. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-639276582 Hello @mimaison thanks for your comments. I have addressed them in the latest push and please take another review. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-632527159 @ryannedolan @mimaison I added the Integration tests for testing this automated consumer offset sync in MM 2.0. When available, I am appreciated for your first pass of review. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-624399781 hi @bseenu @thspinto I updated the PR to handle both cases: (1) new consumer (2) new topic/partition in existing consumer. Please go ahead if you want to test it out sooner. Meanwhile I am writing some integration tests as well to test both cases. Thanks for your feedback This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618732741 Hi @bseenu , it will be very helpful to elaborate the operational sequence of your testing case? e.g. which cluster your consumer initially consume from? Did you switch your consumer from primary to backup cluster? What message your consumer consumed before and after the cluster switch? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
