nresare opened a new pull request #8707: URL: https://github.com/apache/kafka/pull/8707
This mirrors how the KafkaProducer constructors are organised and reduce code duplication. More specifically this PR makes the following changes without changing any behaviour or public API: 1. Move the helper method `propsToMap()` from `KafkaProducer` to `Utils` with the other similar helper `mkMap()` and `mkProperties()` (to make it available to KafkaConsumer). 2. Move the `ConsumerConfig` instantiation to the constructor that actually does the work. 3. Remove the `addDeserializerToConfig()` that operates on `Properties` and it's two tests, as all of those are very similar to the ones that operate on `Map<String, Object>` instances. 4. Have the `KafkaConsumer` constructors that accept `Properties` parameter convert those early to `Map<String, Object>` instances. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
