[GitHub] [kafka] philipnee commented on pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-25 Thread via GitHub 


philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1734529330

   Hey @lianetm - I made some updates based on your last comments. Let me know 
your thoughts!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] philipnee commented on pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-20 Thread via GitHub 


philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1728878443

   @lianetm @kirktrue @dajac - Much thanks for spending time reviewing the PR, 
I tried to address most of the comments in the PR. I'll check back with the 
unit test results - as I've only run them locally.
   
   Let me know if you have more comments to follow up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] philipnee commented on pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-19 Thread via GitHub 


philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1726880993

   @dajac @lianetm - Made some changes based on the comments, but obviously 
broke some existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org