[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1737176802 Backported to 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1737170863 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1736888690 > A new Snappy-Java version was just released: This is the diff between `1.1.10.4` and `1.1.10.5` [xerial/snappy-java@v1.1.10.4...v1.1.10.5](https://github.com/xerial/snappy-java/compare/v1.1.10.4...v1.1.10.5) > > Release announcement: https://github.com/xerial/snappy-java/releases/tag/v1.1.10.5 > > Do we want to update to 1.1.10.5 or leave it at 1.1.10.4? Interesting! Let's do that in parallel. I've created another PR: https://github.com/apache/kafka/pull/14458 for upgrading to 1.1.10.5. Let's wait for the CI build results and decide which one we want to merge into v3.6. Thanks for the info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1736782137 @jlprat , thanks for the comments. PR updated in https://github.com/apache/kafka/pull/14434/commits/c21e79e5ecf46f34b38fa6c1547c615c4d11fe1d . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1736778285 PR updated to add more tests to verify the compressed data can be correctly decompressed and read. Also update the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1736393174 Thanks all. (Sorry, pressing the wrong button on phone). Will verify the decompressed results are able to be correctly read today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1736386116 One question I'd like to get your thoughts. This test is doing: 1. Generate a 2 byte key, and 128 byte value. 2. Create a record using snappy codec compressed. 3. Get the size of the record, which is 197. 4. Add hardcoded 5 for decompression, so, set the max message size to 202. 5. After decompressed, the record size is 203, throw exception, while before bumping snappy version, it'll always be 202. Here's my question: If the decompressed recodes can be read correctly in the consumer side(I haven't tested it, yet), then should we still worry about the additional 1byte after decompression? @divijvaidya @ijuma @jlprat , thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1735496347 One question I'd like to get your thoughts. This test is doing: 1. Generate a 2 byte key, and 128 byte value. 2. Create a record using snappy codec compressed. 3. Get the size of the record, which is 197. 4. Add hardcoded 5 for decompression, so, set the max message size to 202. 5. After decompressed, the record size is 203, throw exception, while before bumping snappy version, it'll always be 202. Here's my question: If the decompressed recodes can be read correctly in the consumer side(I haven't tested it, yet), then should we still worry about the additional 1byte after decompression? @divijvaidya @ijuma @jlprat , thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1735456298 I'll try to investigate more tomorrow, and try to write a simple test case in snappy repo to simulate our test case. But again, if somebody on other timezones wants to take a stab at it, go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1734930832 The failed tests should be this one: `testCleanerWithMessageFormatV0`, which sets the maxMessageSize to 202, and matches the error messages: `Message batch size is 203 bytes in append topartition log-0 which exceeds the maximum configured size of 202.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
