[GitHub] [kafka] tombentley commented on pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-08 Thread GitBox 


tombentley commented on pull request #11301:
URL: https://github.com/apache/kafka/pull/11301#issuecomment-915405715


   Any more comments @ijuma @dajac @showuon ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-07 Thread GitBox 


tombentley commented on pull request #11301:
URL: https://github.com/apache/kafka/pull/11301#issuecomment-914082991


   @dajac @showuon thanks, I've addressed your comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox 


tombentley commented on pull request #11301:
URL: https://github.com/apache/kafka/pull/11301#issuecomment-913760134


   @dajac @mimaison @ijuma perhaps one of you could review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org