[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

[via GitHub]

viktorsomogyi commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1232168660


##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -97,6 +97,16 @@ class ReplicaAlterLogDirsThread(name: String,
 }
   }
 
+  // For ReplicaAlterLogDirsThread, if the partition is marked as failed due 
to an unknown exception and the partition fetch
+  // is suspended, the paused cleanup logic of the partition needs to be 
canceled, otherwise it will lead to serious unexpected
+  // disk usage growth.

Review Comment:
   ```suggestion
 // For ReplicaAlterLogDirsThread, if the future partition is marked as 
failed due to an unknown exception and the partition fetch
 // is suspended, the paused cleanup logic of the current partition needs 
to be resumed, otherwise it can lead to unexpected
 // disk usage growth.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

[via GitHub]

viktorsomogyi commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1219754042


##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -447,11 +447,11 @@ class Partition(val topicPartition: TopicPartition,
   private[cluster] def createLog(isNew: Boolean, isFutureReplica: Boolean, 
offsetCheckpoints: OffsetCheckpoints, topicId: Option[Uuid]): UnifiedLog = {
 def updateHighWatermark(log: UnifiedLog): Unit = {
   val checkpointHighWatermark = offsetCheckpoints.fetch(log.parentDir, 
topicPartition).getOrElse {
-info(s"No checkpointed highwatermark is found for partition 
$topicPartition")
+info(s"No checkpointed highwatermark is found for ${if 
(isFutureReplica) "Future partition" else "partition"} $topicPartition")

Review Comment:
   nit: "future" not "Future"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org