[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream
wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r704545691 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -111,9 +104,24 @@ import static org.junit.Assert.assertThrows; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyMap; +import static org.mockito.Mockito.when; +import static org.mockito.Mockito.mockStatic; +import static org.mockito.Mockito.mockConstruction; +import static org.mockito.Mockito.doAnswer; +import static org.mockito.Mockito.doNothing; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.atMostOnce; +import static org.mockito.Mockito.isA; +import static org.mockito.Mockito.eq; +import static org.mockito.Mockito.anyInt; +import static org.mockito.Mockito.anyLong; +import static org.mockito.Mockito.withSettings; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.spy; +import static org.mockito.MockitoAnnotations.openMocks; -@RunWith(PowerMockRunner.class) Review comment: I remember that I have modified all the streams and I have updated the module build dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream
wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667974480 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -939,7 +939,7 @@ private StreamThread createAndAddStreamThread(final long cacheSizePerThread, fin return streamThread; } -//For KafkaStreamsTest +//Ensure Mockito stub construct with capture argument for KafkaStreamsTest. Review comment: Have changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream
wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667443055 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -61,18 +59,18 @@ import org.apache.kafka.test.MockMetricsReporter; import org.apache.kafka.test.MockProcessorSupplier; import org.apache.kafka.test.TestUtils; -import org.easymock.Capture; -import org.easymock.EasyMock; import org.junit.Assert; import org.junit.Before; import org.junit.Rule; import org.junit.Test; +import org.junit.After; import org.junit.rules.TestName; -import org.junit.runner.RunWith; -import org.powermock.api.easymock.PowerMock; Review comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream
wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667443023 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -96,13 +94,7 @@ import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.safeUniqueTestName; import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitForApplicationState; -import static org.easymock.EasyMock.anyBoolean; import static org.apache.kafka.test.TestUtils.waitForCondition; -import static org.easymock.EasyMock.anyInt; Review comment: I am worried that the current changes for `build,gradle` will cause conflicts. I am going to prepare a separate PR after all related issues are merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream
wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667442355 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -939,6 +939,11 @@ private StreamThread createAndAddStreamThread(final long cacheSizePerThread, fin return streamThread; } +//For KafkaStreamsTest Review comment: I have update code, thanks for all your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream
wycc commented on a change in pull request #11017:
URL: https://github.com/apache/kafka/pull/11017#discussion_r667442158
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -246,10 +246,15 @@ State setState(final State newState) {
public boolean isRunning() {
synchronized (stateLock) {
-return state.isAlive();
+return getIsAlive();
}
}
+//For KafkaStreamTest
+public boolean getIsAlive() {
Review comment:
copy that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
