Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2093906904 > > I have the correct file still saved on my new forced update but I can't link it to this issue. I don't want to revert because I accidently pushed all the commits from the past few months as part of this one. > > maybe you can file a new PR ? https://github.com/apache/kafka/pull/15857 Updated PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2093622997 Ok will do. Ill link it here when done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
chia7712 commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2088823785 > I have the correct file still saved on my new forced update but I can't link it to this issue. I don't want to revert because I accidently pushed all the commits from the past few months as part of this one. maybe you can file a new PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2088813846 I have the correct file still saved on my new forced update but I can't link it to this issue. I don't want to revert because I accidently pushed all the commits from the past few months as part of this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
chia7712 commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2087068199 > Okay I messed up the git a little here (still have much to learn), the current trunk does exist on my [Kafka-16027](https://issues.apache.org/jira/browse/KAFKA-16027) branch but I had to redo it force push which led to auto-closing this branch. Any recommendation on what do to next? that is totally a bad news. Maybe you can take a look at this post (https://stackoverflow.com/questions/3973994/how-can-i-recover-from-an-erronous-git-push-f-origin-master) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2086139400 Okay I messed up the git a little here (still have much to learn), the current trunk does exist on my Kafka-16027 branch but I had to redo it force push which led to auto-closing this branch. Any recommendation on what do to next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili closed pull request #15055: KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership URL: https://github.com/apache/kafka/pull/15055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
chia7712 commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2084584466 any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2030357973 Ya sure, Ill do it at some point today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
philipnee commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2030167845 Hey @Alexander-Aghili - Thanks making the changes. Seems like you've made some changes to the PR but the branch is a bit behind. Would you have time to rebase the branch to trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
github-actions[bot] commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2028541998 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-1868772593 Oh I just noticed https://github.com/apache/kafka/pull/15023 Could this be the source of the issue? After making the change from the PR, the tests passed as expected. Would you still want to utilize this refactor as I saw you also made some edits to MetadataTest. If so, how would you recommend merging the code since there are conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-1868724094 Hi @philipnee, thank you for the feedback! I am a newbie so the guidance is appreciated. I used a lot of the concepts from your refactor but edited some components to make it more readable. However, I have a problem with the testApplyPartialMetadataLeaderUpdate test. For some reason, the behavior is not as expected and I'm not exactly sure why. To be specific, the test fails with the following error: `org.opentest4j.AssertionFailedError: expected: but was: ` on the assertion: [`assertEquals(expectedLeaderInfo, updatedMetadata.currentLeader(tp)); `](https://github.com/Alexander-Aghili/kafka/blob/Kafka-16027/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java?plain=1#L1385) It seems that partition 2 (of 2) in topic 1 is updating the metadata information when it shouldn't. Everything else seems to work fine. I have narrowed the undesired change down to this line: [`Set updatedTps = metadata.updatePartitionLeadership(updates, nodes); `](https://github.com/Alexander-Aghili/kafka/blob/Kafka-16027/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java?plain=1#L1222) which is not entirely surprising because it is the function that enacts the partition leadership update within the metadata. It is strange to me though because the intended effect is "update to partition1's leadership are to be applied, and no update to partition2(so remains at it is)." but the outcome seems to be partition 2 is affected. I'm not sure whether I'm configuring something incorrectly, making an incorrect assumption in the setup, or if there is some other error. Thanks for all the help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
