Re: [PR] KAFKA-16070: move setReadOnly to Headers [kafka]

[via GitHub]

LiangliangSui closed pull request #15097: KAFKA-16070: move setReadOnly to 
Headers
URL: https://github.com/apache/kafka/pull/15097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16070: move setReadOnly to Headers [kafka]

[via GitHub]

github-actions[bot] commented on PR #15097:
URL: https://github.com/apache/kafka/pull/15097#issuecomment-2033466946

   This PR is being marked as stale since it has not had any activity in 90 
days. If you would like to keep this PR alive, please ask a committer for 
review. If the PR has  merge conflicts, please update it with the latest from 
trunk (or appropriate release branch)  If this PR is no longer valid or 
desired, please feel free to close it. If no activity occurs in the next 30 
days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16070: move setReadOnly to Headers [kafka]

[via GitHub]

hachikuji commented on code in PR #15097:
URL: https://github.com/apache/kafka/pull/15097#discussion_r1440744523


##
clients/src/main/java/org/apache/kafka/common/header/Headers.java:
##
@@ -69,4 +69,10 @@ public interface Headers extends Iterable {
  */
 Header[] toArray();
 
+/**
+ * Set Header to readonly.
+ */
+default void setReadOnly() {

Review Comment:
   Hmm, I don't think `setReadOnly` was ever intended to be public. The class 
`RecordHeaders` is in `internals`. We just use this method as a way to prevent 
modification once the headers have been passed to the producer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org