Re: [PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (1/3) [kafka]

[via GitHub]

gharris1727 merged PR #15520:
URL: https://github.com/apache/kafka/pull/15520


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (1/3) [kafka]

[via GitHub]

gharris1727 commented on PR #15520:
URL: https://github.com/apache/kafka/pull/15520#issuecomment-2027797163

   Test failures appear unrelated, and the connect runtime tests pass locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (1/3) [kafka]

[via GitHub]

gharris1727 commented on code in PR #15520:
URL: https://github.com/apache/kafka/pull/15520#discussion_r1544876870


##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -329,6 +329,11 @@ public static String LOGGER_CLUSTER_KEY(String namespace) {
 private final Map fencableProducerProps;
 private final Time time;
 
+//VisibleForTesting
+void setConfigLog(KafkaBasedLog configLog) {
+this.configLog = configLog;

Review Comment:
   I don't like this, but I think fixing it is going to also require solving 
the this-escape in the constructor, which looks nasty. Good enough for now, and 
we can address it later after EasyMock is gone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (1/3) [kafka]

[via GitHub]

hgeraldino opened a new pull request, #15520:
URL: https://github.com/apache/kafka/pull/15520

   This is the last remaining Kafka Connect test that needs migration from 
PowerMock/EasyMock to Mockito.
   
   Following the same approach as the `WorkerSinkTaskTest` migration, which was 
migrated in [1](https://github.com/apache/kafka/pull/14663) 
[2](https://github.com/apache/kafka/pull/15313) 
[3](https://github.com/apache/kafka/pull/15316) separate batches, this PR 
contains just ~ 1/3 of the total number of test methods, which should make the 
review "easier".
   
   As usual, I Iook forward for your comments and feedback @C0urante 
@gharris1727 @divijvaidya @clolov @mukkachaitanya 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org