Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]
mjsax merged PR #15681: URL: https://github.com/apache/kafka/pull/15681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]
apoorvmittal10 commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2050055971 > LGTM -- retriggered Jenkins (failure seems unrelated, but want to sanify check) -- Can merge afterwards. Thanks @mjsax. I can see unrelated tests failures as well and green on jdk 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]
apoorvmittal10 commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2042866833 > Tiny nit. It's KIP-1019 I think, not KIP-109. Corrected the description. Thanks @AndrewJSchofield. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]
AndrewJSchofield commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2042864722 Tiny nit. It's KIP-1019 I think, not KIP-109. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]
apoorvmittal10 opened a new pull request, #15681: URL: https://github.com/apache/kafka/pull/15681 The PR implements the changes defined in [KIP-109](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1019%3A+Expose+method+to+determine+Metric+Measurability) which exposes method to check if metric is of type Measurable. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org