Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
showuon merged PR #15409: URL: https://github.com/apache/kafka/pull/15409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
showuon commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2041009723 Confirmed all tests passed after https://github.com/apache/kafka/pull/15335 merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
showuon commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2036106373 > > @gaurav-narula , the new added KRaft tests are failing in our test env. The logs are [here](https://drive.google.com/file/d/1CbxgH8eswEXX0YDEJpZn7B9Vd4x-gfo4/view?usp=sharing). Could you help check and fix them? Thanks. > > I believe this pr depends on #15335 OK, let's wait until #15335 merged and then check again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
OmniaGM commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2035191271 > @gaurav-narula , the new added KRaft tests are failing in our test env. The logs are [here](https://drive.google.com/file/d/1CbxgH8eswEXX0YDEJpZn7B9Vd4x-gfo4/view?usp=sharing). Could you help check and fix them? Thanks. I believe this pr depends on https://github.com/apache/kafka/pull/15335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
showuon commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2034010084 @gaurav-narula , the new added KRaft tests are failing in our test env. The logs are [here](https://drive.google.com/file/d/1CbxgH8eswEXX0YDEJpZn7B9Vd4x-gfo4/view?usp=sharing). Could you help check and fix them? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
soarez commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2033175375 @showuon could you have a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
soarez commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-1983165932 @rondagostino @cmccabe can one of you have a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
pprovenzano commented on code in PR #15409: URL: https://github.com/apache/kafka/pull/15409#discussion_r1513010665 ## tests/kafkatest/tests/core/log_dir_failure_test.py: ## @@ -84,20 +84,25 @@ def __init__(self, test_context): self.num_consumers = 1 def setUp(self): -self.zk.start() +if self.zk: +self.zk.start() def min_cluster_size(self): """Override this since we're adding services outside of the constructor""" return super(LogDirFailureTest, self).min_cluster_size() + self.num_producers * 2 + self.num_consumers * 2 -@cluster(num_nodes=9) -@matrix(bounce_broker=[False, True], broker_type=["leader", "follower"], security_protocol=["PLAINTEXT"]) -def test_replication_with_disk_failure(self, bounce_broker, security_protocol, broker_type): +@cluster(num_nodes=8) +@matrix(bounce_broker=[False, True], broker_type=["leader", "follower"], security_protocol=["PLAINTEXT"], metadata_quorum=[quorum.zk]) +@cluster(num_nodes=7) +@matrix(bounce_broker=[False, True], broker_type=["leader", "follower"], security_protocol=["PLAINTEXT"], metadata_quorum=[quorum.combined_kraft]) Review Comment: I agree with dropping the combined test here. I'm not sure I would ever suggest running JBOD in combined mode. A separate process for broker and controller on the same node would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
soarez commented on code in PR #15409: URL: https://github.com/apache/kafka/pull/15409#discussion_r1497794379 ## tests/kafkatest/tests/core/log_dir_failure_test.py: ## @@ -84,20 +84,25 @@ def __init__(self, test_context): self.num_consumers = 1 def setUp(self): -self.zk.start() +if self.zk: +self.zk.start() def min_cluster_size(self): """Override this since we're adding services outside of the constructor""" return super(LogDirFailureTest, self).min_cluster_size() + self.num_producers * 2 + self.num_consumers * 2 -@cluster(num_nodes=9) -@matrix(bounce_broker=[False, True], broker_type=["leader", "follower"], security_protocol=["PLAINTEXT"]) -def test_replication_with_disk_failure(self, bounce_broker, security_protocol, broker_type): +@cluster(num_nodes=8) +@matrix(bounce_broker=[False, True], broker_type=["leader", "follower"], security_protocol=["PLAINTEXT"], metadata_quorum=[quorum.zk]) +@cluster(num_nodes=7) +@matrix(bounce_broker=[False, True], broker_type=["leader", "follower"], security_protocol=["PLAINTEXT"], metadata_quorum=[quorum.combined_kraft]) Review Comment: Unsure about the value of repeating the tests for `quorum.combined_kraft`, this mode isn't recommended for production, it's easier to cover it in java integration tests and makes this suite slower. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
gaurav-narula commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-1956778458 CC: @soarez @OmniaGM @pprovenzano @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-16293: Test log directory failure in Kraft [kafka]
gaurav-narula opened a new pull request, #15409: URL: https://github.com/apache/kafka/pull/15409 Enables log directory failure system test for all Kraft modes in addition to ZK mode. This depends on #15335 being merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
