Re: [PR] MINOR: Cleanup in MetadataShell [kafka]

[via GitHub]

wernerdv closed pull request #15672: MINOR: Cleanup in MetadataShell
URL: https://github.com/apache/kafka/pull/15672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Cleanup in MetadataShell [kafka]

[via GitHub]

chia7712 commented on code in PR #15672:
URL: https://github.com/apache/kafka/pull/15672#discussion_r1554976395


##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -281,13 +278,12 @@ public static void main(String[] args) throws Exception {
 }
 }
 
-void waitUntilCaughtUp() throws ExecutionException, InterruptedException {
+void waitUntilCaughtUp() throws InterruptedException {
 while (true) {
 if (loader.lastAppliedOffset() > 0) {
 return;
 }
 Thread.sleep(10);
 }
-//snapshotFileReader.caughtUpFuture().get();

Review Comment:
   not sure whether this wait is necessary or a exception?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Cleanup in MetadataShell [kafka]

[via GitHub]

wernerdv commented on PR #15672:
URL: https://github.com/apache/kafka/pull/15672#issuecomment-2040983038

   @cmccabe @chia7712 Hello, PTAL. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINOR: Cleanup in MetadataShell [kafka]

[via GitHub]

wernerdv opened a new pull request, #15672:
URL: https://github.com/apache/kafka/pull/15672

   Removed unnecessary exceptions from the throw list.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org