Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-07 Thread via GitHub


chia7712 merged PR #15666:
URL: https://github.com/apache/kafka/pull/15666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-06 Thread via GitHub


nizhikov commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2041051125

   @chia7712 latest trunk merged. Please, take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-06 Thread via GitHub


nizhikov commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2041051035

   Trunk test names:
   
   ![Снимок экрана 2024-04-06 в 14 12 
12](https://github.com/apache/kafka/assets/880793/3886034f-de2c-4a73-9ef6-4afa55fde594)
   
   PR test names:
   
   ![Снимок экрана 2024-04-06 в 14 11 
04](https://github.com/apache/kafka/assets/880793/7af51cfa-fb81-4835-a3b9-5434f4e7c888)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub


chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2040912811

   @nizhikov Could you please rebase code to see the display name of tools test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub


chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039276618

   sorry :( 
   
   the correct PR is #15663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub


nizhikov commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039274380

   @chia7712 Can you, please, double check PR number? It sees #15664 not 
related to my changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub


chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039262579

   @nizhikov thanks for this patch. let's wait for #15664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub


nizhikov opened a new pull request, #15666:
URL: https://github.com/apache/kafka/pull/15666

   This PR adds `junit-platform.properties` to `tools` and removes outdated 
constant from java code.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org