Re: [PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

[via GitHub]

TaiJuWu commented on code in PR #15749:
URL: https://github.com/apache/kafka/pull/15749#discussion_r1569739083


##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -1082,7 +1082,7 @@ private[kafka] class Processor(
   // `protected` for test usage
   protected[network] def sendResponse(response: RequestChannel.Response, 
responseSend: Send): Unit = {
 val connectionId = response.request.context.connectionId
-trace(s"Socket server received response to send to $connectionId, 
registering for write and sending data: $response")
+trace(s"Socket server received response from $connectionId, registering 
for write and sending data: $response")

Review Comment:
   Oh, you’re right. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

[via GitHub]

TaiJuWu closed pull request #15749: MINOR: Modify SocketServer#sendResponse 
trace msg
URL: https://github.com/apache/kafka/pull/15749


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

[via GitHub]

splett2 commented on code in PR #15749:
URL: https://github.com/apache/kafka/pull/15749#discussion_r1569578496


##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -1082,7 +1082,7 @@ private[kafka] class Processor(
   // `protected` for test usage
   protected[network] def sendResponse(response: RequestChannel.Response, 
responseSend: Send): Unit = {
 val connectionId = response.request.context.connectionId
-trace(s"Socket server received response to send to $connectionId, 
registering for write and sending data: $response")
+trace(s"Socket server received response from $connectionId, registering 
for write and sending data: $response")

Review Comment:
   why is the suggested comment more correct? we are sending the response _to_ 
the connection, we are not receiving a response from the connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINOR: Modify SocketServer#sendResponse trace msg [kafka]

[via GitHub]

TaiJuWu opened a new pull request, #15749:
URL: https://github.com/apache/kafka/pull/15749

   As title.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org