Re: [PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

[via GitHub]

chia7712 merged PR #15611:
URL: https://github.com/apache/kafka/pull/15611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

[via GitHub]

soarez commented on PR #15611:
URL: https://github.com/apache/kafka/pull/15611#issuecomment-2026205805

   Seems like a gray area to me. Regardless, I'd like to encourage @brandboat 
to keep looking for opportunities to cleanup and refactor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

[via GitHub]

chia7712 commented on PR #15611:
URL: https://github.com/apache/kafka/pull/15611#issuecomment-2024745523

   That’s just my two cents. It is a trivial patch but I'm fine to merge it due 
to following reasons.
   
   1. this cleanup does not burn out kafka ( In fact, I feel we do need more 
cleanup and refactor ...)
   2. as a friendly community, it is acceptable that new contributor files 
trivial PR even though it does not bring obvious benefit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

[via GitHub]

AndrewJSchofield commented on PR #15611:
URL: https://github.com/apache/kafka/pull/15611#issuecomment-2024044460

   I'm not sure this is really an improvement. It's just an overloading method 
which has one existing caller.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

[via GitHub]

brandboat opened a new pull request, #15611:
URL: https://github.com/apache/kafka/pull/15611

   The method `ApiVersionsResponse#filterApis(RecordVersion, 
ApiMessageType.ListenerType)` is only used in test, we can remove it and invoke 
the other one.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org