Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]
chia7712 merged PR #15713: URL: https://github.com/apache/kafka/pull/15713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]
chia7712 commented on PR #15713: URL: https://github.com/apache/kafka/pull/15713#issuecomment-2061259436 @AyoubOm thanks for your contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]
AyoubOm commented on PR #15713: URL: https://github.com/apache/kafka/pull/15713#issuecomment-2060923661 @chia7712 please check this when you have time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]
AyoubOm commented on code in PR #15713: URL: https://github.com/apache/kafka/pull/15713#discussion_r1566436979 ## streams/src/main/java/org/apache/kafka/streams/kstream/NamedOperation.java: ## @@ -17,7 +17,7 @@ package org.apache.kafka.streams.kstream; /** - * Default interface which can be used to personalized the named of operations, internal topics or store. + * Default interface which can be used to customize the named of operations, internal topics or store. Review Comment: Thanks @johnnychhsu, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]
johnnychhsu commented on code in PR #15713: URL: https://github.com/apache/kafka/pull/15713#discussion_r1565877195 ## streams/src/main/java/org/apache/kafka/streams/kstream/NamedOperation.java: ## @@ -17,7 +17,7 @@ package org.apache.kafka.streams.kstream; /** - * Default interface which can be used to personalized the named of operations, internal topics or store. + * Default interface which can be used to customize the named of operations, internal topics or store. Review Comment: shall we also change the description to 'the name of operations'? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: fix duplicated return and other streams docs typos [kafka]
johnnychhsu commented on PR #15713: URL: https://github.com/apache/kafka/pull/15713#issuecomment-2056975870 thanks for the pr! this looks good to me, leave a simple comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINOR: fix duplicated return and other streams docs typos [kafka]
AyoubOm opened a new pull request, #15713: URL: https://github.com/apache/kafka/pull/15713 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
