Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
jolshan merged PR #14747: URL: https://github.com/apache/kafka/pull/14747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
jolshan commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1815497819 @chb2ab don't worry about changing instance type. AK builds tend to run slower than local machines. Most of these are consistent with trunk. I think the only two that were questionable were: kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures kafka.api.PlaintextProducerSendTest.testAutoCreateTopic You mentioned offline that running these several times locally for your branch and trunk yielded about the same results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1814841765 > I've run all the failing tests locally and they passed (kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures after a retry) > > > Build / JDK 8 and Scala 2.12 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=zk – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testConsumptionWithBrokerFailures() – kafka.api.ConsumerBounceTest > > Build / JDK 21 and Scala 2.13 / testAutoCreateTopic(String).quorum=zk – kafka.api.PlaintextProducerSendTest > > Build / JDK 21 and Scala 2.13 / testTransactionAfterTransactionIdExpiresButProducerIdRemains(String).quorum=kraft – kafka.api.ProducerIdExpirationTest > > Build / JDK 17 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – kafka.network.DynamicConnectionQuotaTest > > Build / JDK 11 and Scala 2.13 / [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest > > Build / JDK 21 and Scala 2.13 / [2] tlsProtocol=TLSv1.2, useInlinePem=true – org.apache.kafka.common.network.SslTransportLayerTest > > Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest > > Build / JDK 17 and Scala 2.13 / testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 17 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 11 and Scala 2.13 / testNoPublishEmptyImage() – org.apache.kafka.image.loader.MetadataLoaderTest > > Build / JDK 21 and Scala 2.13 / testRemoteLogSizeCalculationWithSegmentsOfDifferentEpochs() – org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerTest > > Build / JDK 8 and Scala 2.12 / shouldAddNamedTopologyToRunningApplicationWithSingleInitialNamedTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest > > Build / JDK 21 and Scala 2.13 / shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest Given these tests pass locally, I guess it's likely a hardware issue causing them to fail in Jenkins? I'm running on a MacBook Pro (2019, Monterey) with a 2.6 GHz 6-Core Intel Core i7 processor, I'm not sure what Jenkins is using or how to change the instance type. cc @dajac @jolshan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1814840139 > I've run all the failing tests locally and they passed (kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures after a retry) > > > Build / JDK 8 and Scala 2.12 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=zk – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testConsumptionWithBrokerFailures() – kafka.api.ConsumerBounceTest > > Build / JDK 21 and Scala 2.13 / testAutoCreateTopic(String).quorum=zk – kafka.api.PlaintextProducerSendTest > > Build / JDK 21 and Scala 2.13 / testTransactionAfterTransactionIdExpiresButProducerIdRemains(String).quorum=kraft – kafka.api.ProducerIdExpirationTest > > Build / JDK 17 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – kafka.network.DynamicConnectionQuotaTest > > Build / JDK 11 and Scala 2.13 / [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest > > Build / JDK 21 and Scala 2.13 / [2] tlsProtocol=TLSv1.2, useInlinePem=true – org.apache.kafka.common.network.SslTransportLayerTest > > Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest > > Build / JDK 17 and Scala 2.13 / testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 17 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 11 and Scala 2.13 / testNoPublishEmptyImage() – org.apache.kafka.image.loader.MetadataLoaderTest > > Build / JDK 21 and Scala 2.13 / testRemoteLogSizeCalculationWithSegmentsOfDifferentEpochs() – org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerTest > > Build / JDK 8 and Scala 2.12 / shouldAddNamedTopologyToRunningApplicationWithSingleInitialNamedTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest > > Build / JDK 21 and Scala 2.13 / shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest Given these tests pass locally, I guess it's likely a hardware issue causing them to fail in Jenkins? I'm running on a MacBook Pro (16-inch, 2019) with a 2.6 GHz 6-Core Intel Core i7 processor, I'm not sure what Jenkins is using or how to change the instance type. cc @dajac @jolshan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1814839447 > I've run all the failing tests locally and they passed (kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures after a retry) > > > Build / JDK 8 and Scala 2.12 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=zk – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testConsumptionWithBrokerFailures() – kafka.api.ConsumerBounceTest > > Build / JDK 21 and Scala 2.13 / testAutoCreateTopic(String).quorum=zk – kafka.api.PlaintextProducerSendTest > > Build / JDK 21 and Scala 2.13 / testTransactionAfterTransactionIdExpiresButProducerIdRemains(String).quorum=kraft – kafka.api.ProducerIdExpirationTest > > Build / JDK 17 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – kafka.network.DynamicConnectionQuotaTest > > Build / JDK 11 and Scala 2.13 / [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest > > Build / JDK 21 and Scala 2.13 / [2] tlsProtocol=TLSv1.2, useInlinePem=true – org.apache.kafka.common.network.SslTransportLayerTest > > Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest > > Build / JDK 17 and Scala 2.13 / testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 17 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 11 and Scala 2.13 / testNoPublishEmptyImage() – org.apache.kafka.image.loader.MetadataLoaderTest > > Build / JDK 21 and Scala 2.13 / testRemoteLogSizeCalculationWithSegmentsOfDifferentEpochs() – org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerTest > > Build / JDK 8 and Scala 2.12 / shouldAddNamedTopologyToRunningApplicationWithSingleInitialNamedTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest > > Build / JDK 21 and Scala 2.13 / shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest Given these tests pass locally, I guess it's likely a hardware issue causing them to fail in Jenkins? I'm running on a MacBook Pro (16-inch, 2019), with a 2.6 GHz 6-Core Intel Core i7 processor, I'm not sure what Jenkins is using or how to change the instance type. cc @dajac @jolshan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1814838171 > I've run all the failing tests locally and they passed (kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures after a retry) > > > Build / JDK 8 and Scala 2.12 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=zk – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest > > Build / JDK 17 and Scala 2.13 / testConsumptionWithBrokerFailures() – kafka.api.ConsumerBounceTest > > Build / JDK 21 and Scala 2.13 / testAutoCreateTopic(String).quorum=zk – kafka.api.PlaintextProducerSendTest > > Build / JDK 21 and Scala 2.13 / testTransactionAfterTransactionIdExpiresButProducerIdRemains(String).quorum=kraft – kafka.api.ProducerIdExpirationTest > > Build / JDK 17 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – kafka.network.DynamicConnectionQuotaTest > > Build / JDK 11 and Scala 2.13 / [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest > > Build / JDK 21 and Scala 2.13 / [2] tlsProtocol=TLSv1.2, useInlinePem=true – org.apache.kafka.common.network.SslTransportLayerTest > > Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest > > Build / JDK 17 and Scala 2.13 / testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 17 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest > > Build / JDK 11 and Scala 2.13 / testNoPublishEmptyImage() – org.apache.kafka.image.loader.MetadataLoaderTest > > Build / JDK 21 and Scala 2.13 / testRemoteLogSizeCalculationWithSegmentsOfDifferentEpochs() – org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerTest > > Build / JDK 8 and Scala 2.12 / shouldAddNamedTopologyToRunningApplicationWithSingleInitialNamedTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest > > Build / JDK 21 and Scala 2.13 / shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest Given these tests pass locally, I guess it's likely a hardware issue causing them to fail in Jenkins? I'm running on a MacBook Pro (16-inch, 2019), with a 2.6 GHz 6-Core Intel Core i7 processor, I'm not sure what Jenkins is using or how to change the instance type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1813016931 @jolshan yes it was a clean revert, no conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
jolshan commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1812965942 @chb2ab was the re-revert clean? Any conflicts that needed resolving? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab commented on PR #14747: URL: https://github.com/apache/kafka/pull/14747#issuecomment-1812956129 I've run all the failing tests locally and they passed (kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures after a retry) > Build / JDK 8 and Scala 2.12 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=zk – integration.kafka.server.FetchFromFollowerIntegrationTest Build / JDK 17 and Scala 2.13 / testRackAwareRangeAssignor(String).quorum=kraft – integration.kafka.server.FetchFromFollowerIntegrationTest Build / JDK 17 and Scala 2.13 / testConsumptionWithBrokerFailures() – kafka.api.ConsumerBounceTest Build / JDK 21 and Scala 2.13 / testAutoCreateTopic(String).quorum=zk – kafka.api.PlaintextProducerSendTest Build / JDK 21 and Scala 2.13 / testTransactionAfterTransactionIdExpiresButProducerIdRemains(String).quorum=kraft – kafka.api.ProducerIdExpirationTest Build / JDK 17 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – kafka.network.DynamicConnectionQuotaTest Build / JDK 11 and Scala 2.13 / [3] Type=ZK, MetadataVersion=3.6-IV2, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest Build / JDK 21 and Scala 2.13 / [2] tlsProtocol=TLSv1.2, useInlinePem=true – org.apache.kafka.common.network.SslTransportLayerTest Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest Build / JDK 17 and Scala 2.13 / testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest Build / JDK 17 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest Build / JDK 11 and Scala 2.13 / testNoPublishEmptyImage() – org.apache.kafka.image.loader.MetadataLoaderTest Build / JDK 21 and Scala 2.13 / testRemoteLogSizeCalculationWithSegmentsOfDifferentEpochs() – org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerTest Build / JDK 8 and Scala 2.12 / shouldAddNamedTopologyToRunningApplicationWithSingleInitialNamedTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest Build / JDK 21 and Scala 2.13 / shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology() – org.apache.kafka.streams.integration.NamedTopologyIntegrationTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]
chb2ab opened a new pull request, #14747: URL: https://github.com/apache/kafka/pull/14747 Investigating `org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest` failure This reverts commit a98bd7d65fb5a3a188ff524db7619dc7fe4257fa. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
