[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-07-01 Thread Luke Chen (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149206#comment-17149206
 ] 

Luke Chen commented on KAFKA-10220:
---

[~tombentley], I'll submit a PR for your review later. Thanks.

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Assignee: Luke Chen
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-07-01 Thread Tom Bentley (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149192#comment-17149192
 ] 

Tom Bentley commented on KAFKA-10220:
-

[~omkreddy] I'm happy to fix it, but Luke is already assigned. In any case, 
sorry folks ☹. I took another look at my PR and since {{configurationKeys}} is 
the only nullable field I don't think it's a systematic mistake.


One other thought: We could easily have the message generator add {{@Nullable}} 
annotations to nullable fields to enable static checking for this kind of error.

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Assignee: Luke Chen
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-07-01 Thread Manikumar (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149170#comment-17149170
 ] 

Manikumar commented on KAFKA-10220:
---

looks like this got introduced in [https://github.com/apache/kafka/pull/8312]

cc [~tombentley]

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Assignee: Luke Chen
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread huxihx (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148774#comment-17148774
 ] 

huxihx commented on KAFKA-10220:


Well, from the broker perspective, you are right. Only trunk is affected. What 
I mean is we'll also hit NPE when using 2.6 clients talking to trunk broker.

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Assignee: Luke Chen
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Ismael Juma (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148756#comment-17148756
 ] 

Ismael Juma commented on KAFKA-10220:
-

>From the link you referenced, it seems like this only affects trunk, not 2.6.

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Assignee: Luke Chen
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread huxihx (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148738#comment-17148738
 ] 

huxihx commented on KAFKA-10220:


[~ijuma] This should affect 2.6 as well since `configurationKeys` starts to be 
initialized in 2.7, due to the refinement introduced by 
[KAFKA-9432|https://issues.apache.org/jira/browse/KAFKA-9432]. Anyway, since 
`configurationKeys` is a nullable, an empty check should be added when 
processing the resources in AdminManager.

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Assignee: Luke Chen
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Ismael Juma (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148680#comment-17148680
 ] 

Ismael Juma commented on KAFKA-10220:
-

Does this affect 2.6 as well or just trunk?

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148576#comment-17148576
 ] 

Edoardo Comar commented on KAFKA-10220:
---

{{also note that if the describe comes from the current trunk, it succeeds:}}

{{(trunk)$ bin/kafka-topics.sh --bootstrap-server localhost:9092 
--describe(trunk)$ bin/kafka-topics.sh --bootstrap-server Topic: topic1 
PartitionCount: 1 ReplicationFactor: 1 Configs: segment.bytes=1073741824 Topic: 
topic1 Partition: 0 Leader: 0 Replicas: 0 Isr: 0Topic: topic25 PartitionCount: 
1 ReplicationFactor: 1 Configs: segment.bytes=1073741824 Topic: topic25 
Partition: 0 Leader: 0 Replicas: 0 Isr: 0ecomar@edoibmmac2 
~/devel/ws-github/apache/kafka (trunk)$ }}

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148575#comment-17148575
 ] 

Edoardo Comar commented on KAFKA-10220:
---

ok, a bit more steps to reproduce looks like the issue was linked to having 
created and described a topic with 2.5

{{#on current trunk}}
{{$ git lg}}
{{55b5b248c - (HEAD -> trunk, origin/trunk, origin/HEAD)}}

{{#build}}
{{$ ./gradlew clean}}
{{$ ./gradlew assemble -PscalaVersion=2.12}}

{{#run zookepeer and one broker}}
{{$ export SCALA_VERSION=2.12}}
{{$  bin/zookeeper-server-start.sh config/zookeeper.properties}}
{{$ bin/kafka-server-start.sh config/server.properties}}

{{#create topic with CLI}}
{{$ bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic 
topic1 --partitions 1 --replication-factor 1}}
{{# works fine}}
{{# describe topic with CLI}}
{{$ bin/kafka-topics.sh --bootstrap-server localhost:9092 --describe}}
{{Topic: topic1 PartitionCount: 1 ReplicationFactor: 1 Configs: 
segment.bytes=1073741824Topic: topic1 PartitionCount: 1 ReplicationFactor: 1 
Configs: segment.bytes=1073741824 Topic: topic1 Partition: 0 Leader: 0 
Replicas: 0 Isr: 0}}
{{#works fine}}

{{in another terminal, use the kafka_2.13-2.5.0 binary distribution:}}
{{$ bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic 
topic25 --partitions 1 --replication-factor 1}}
{{Created topic topic25.}}
{{#now describe it (still with 2.5) ... boom}}
{{$ bin/kafka-topics.sh --bootstrap-server localhost:9092 --describe}}
{{Error while executing topic command : 
org.apache.kafka.common.errors.UnknownServerException: The server experienced 
an unexpected error when processing the request.Error while executing topic 
command : org.apache.kafka.common.errors.UnknownServerException: The server 
experienced an unexpected error when processing the request.[2020-06-30 
12:39:48,581] ERROR java.util.concurrent.ExecutionException: 
org.apache.kafka.common.errors.UnknownServerException: The server experienced 
an unexpected error when processing the request. at 
org.apache.kafka.common.internals.KafkaFutureImpl.wrapAndThrow(KafkaFutureImpl.java:45)}}

{{#in the broker terminal, the exception is }}

{{[2020-06-30 12:40:27,543] ERROR [Admin Manager on Broker 0]: Error processing 
describe configs request for resource DescribeConfigsResource(resourceType=2, 
resourceName='topic1', configurationKeys=null) 
(kafka.server.AdminManager)[2020-06-30 12:40:27,543] ERROR [Admin Manager on 
Broker 0]: Error processing describe configs request for resource 
DescribeConfigsResource(resourceType=2, resourceName='topic1', 
configurationKeys=null) 
(kafka.server.AdminManager)java.lang.NullPointerException at 
kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:359) at 
kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:357)
 at 
scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:291)
 at scala.collection.Iterator.foreach(Iterator.scala:943) at 
scala.collection.Iterator.foreach$(Iterator.scala:943) at 
scala.collection.AbstractIterator.foreach(Iterator.scala:1431) at 
scala.collection.IterableLike.foreach(IterableLike.scala:74) at 
scala.collection.IterableLike.foreach$(IterableLike.scala:73) at 
scala.collection.AbstractIterable.foreach(Iterable.scala:56) at 
scala.collection.TraversableLike.filterImpl(TraversableLike.scala:290) at 
scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:284) at 
scala.collection.AbstractTraversable.filterImpl(Traversable.scala:108) at 
scala.collection.TraversableLike.filter(TraversableLike.scala:382) at 
scala.collection.TraversableLike.filter$(TraversableLike.scala:382) at 
scala.collection.AbstractTraversable.filter(Traversable.scala:108) at 
kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:357) at 
kafka.server.AdminManager.describeConfigs(AdminManager.scala:350) at 
kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2594) at 
kafka.server.KafkaApis.handle(KafkaApis.scala:165) at 
kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70) at 
java.base/java.lang.Thread.run(Thread.java:834)}}

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148564#comment-17148564
 ] 

Edoardo Comar commented on KAFKA-10220:
---

[~huxi_2b] I initially hit this when using the 2.5.0 cli (from the binary 
distribution) against trunk (running in eclipse)

I was later able to reproduce using the cli built from trunk (./gradlew 
assemble -PscalaVersion=2.12)

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread huxihx (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148550#comment-17148550
 ] 

huxihx commented on KAFKA-10220:


[~ecomar]  Thanks for reporting. I could not reproduce this issue with trunk. 
Are you using the latest code for clients?

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Priority: Major
>
> In current trunk code 
>  Describing a topic from the CLI can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null?)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148535#comment-17148535
 ] 

Edoardo Comar commented on KAFKA-10220:
---

deserialized request data has a null configurationKeys



{{DescribeConfigsRequestData(resources=[DescribeConfigsResource(resourceType=2, 
resourceName='topic1', configurationKeys=null),...}}

> NPE when describing resources
> -
>
> Key: KAFKA-10220
> URL: https://issues.apache.org/jira/browse/KAFKA-10220
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Edoardo Comar
>Priority: Major
>
> In current trunk code 
> Describing a topic can fail with an NPE in the broker
> on the line 
> {{          
> resource.configurationKeys.asScala.forall(_.contains(configName))}}
>  
> (configurationKeys is null?)
> {{[2020-06-30 11:10:39,464] ERROR [Admin Manager on Broker 0]: Error 
> processing describe configs request for resource 
> DescribeConfigsResource(resourceType=2, resourceName='topic1', 
> configurationKeys=null) 
> (kafka.server.AdminManager)}}{{java.lang.NullPointerException}}{{at 
> kafka.server.AdminManager.$anonfun$describeConfigs$3(AdminManager.scala:395)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$3$adapted(AdminManager.scala:393)}}{{at
>  
> scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:248)}}{{at
>  scala.collection.Iterator.foreach(Iterator.scala:929)}}{{at 
> scala.collection.Iterator.foreach$(Iterator.scala:929)}}{{at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1417)}}{{at 
> scala.collection.IterableLike.foreach(IterableLike.scala:71)}}{{at 
> scala.collection.IterableLike.foreach$(IterableLike.scala:70)}}{{at 
> scala.collection.AbstractIterable.foreach(Iterable.scala:54)}}{{at 
> scala.collection.TraversableLike.filterImpl(TraversableLike.scala:247)}}{{at 
> scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:245)}}{{at 
> scala.collection.AbstractTraversable.filterImpl(Traversable.scala:104)}}{{at 
> scala.collection.TraversableLike.filter(TraversableLike.scala:259)}}{{at 
> scala.collection.TraversableLike.filter$(TraversableLike.scala:259)}}{{at 
> scala.collection.AbstractTraversable.filter(Traversable.scala:104)}}{{at 
> kafka.server.AdminManager.createResponseConfig$1(AdminManager.scala:393)}}{{at
>  
> kafka.server.AdminManager.$anonfun$describeConfigs$1(AdminManager.scala:412)}}{{at
>  scala.collection.immutable.List.map(List.scala:283)}}{{at 
> kafka.server.AdminManager.describeConfigs(AdminManager.scala:386)}}{{at 
> kafka.server.KafkaApis.handleDescribeConfigsRequest(KafkaApis.scala:2595)}}{{at
>  kafka.server.KafkaApis.handle(KafkaApis.scala:165)}}{{at 
> kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:70)}}{{at 
> java.lang.Thread.run(Thread.java:748)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)