[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297750#comment-17297750 ] Matthias J. Sax commented on KAFKA-10434: - [~jeqo] With upcoming 3.0 release, would you be interested to pick up this ticket? > Remove deprecated methods on WindowStore > > > Key: KAFKA-10434 > URL: https://issues.apache.org/jira/browse/KAFKA-10434 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jorge Esteban Quilcate Otoya >Assignee: Jorge Esteban Quilcate Otoya >Priority: Blocker > Labels: needs-kip > Fix For: 3.0.0 > > > From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and > [https://github.com/apache/kafka/pull/9138#discussion_r474995606] : > WindowStore contains ReadOnlyWindowStore methods. > We could consider: > * Moving read methods from WindowStore to ReadOnlyWindowStore and/or > * Consider removing long based methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187962#comment-17187962 ] John Roesler commented on KAFKA-10434: -- Marked as a 3.0 blocker so we will be sure to consider removing the methods at the time of the 3.0 release. If we decide at that time not to do it yet, we'll just move it to the 4.0 release. > Remove deprecated methods on WindowStore > > > Key: KAFKA-10434 > URL: https://issues.apache.org/jira/browse/KAFKA-10434 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jorge Esteban Quilcate Otoya >Priority: Blocker > Labels: needs-kip > Fix For: 3.0.0 > > > From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and > [https://github.com/apache/kafka/pull/9138#discussion_r474995606] : > WindowStore contains ReadOnlyWindowStore methods. > We could consider: > * Moving read methods from WindowStore to ReadOnlyWindowStore and/or > * Consider removing long based methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185325#comment-17185325 ] Jorge Esteban Quilcate Otoya commented on KAFKA-10434: -- Also kind of weird to have Instant-based methods on WindowStore and only long-based methods in SessionStore. Regardless of un-deprecating long-based methods or not, we can consider aliging both interfaces. > Remove deprecated methods on WindowStore > > > Key: KAFKA-10434 > URL: https://issues.apache.org/jira/browse/KAFKA-10434 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jorge Esteban Quilcate Otoya >Priority: Major > > From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and > [https://github.com/apache/kafka/pull/9138#discussion_r474995606] : > WindowStore contains ReadOnlyWindowStore methods. > We could consider: > * Moving read methods from WindowStore to ReadOnlyWindowStore and/or > * Consider removing long based methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184804#comment-17184804 ] Sophie Blee-Goldman commented on KAFKA-10434: - Also, if there are performance concerns with using Instant, then why did we deprecate all of the public APIs that use long? We shouldn't set the bar lower for our own internal use vs users of IQ, we have no idea what their performance requirements might be and they could be making many calls per second. I think we should un-deprecate them... Of course, if we're going to be completely overhauling IQ shortly anyways, maybe it's not worth a KIP to un-deprecate it (do we actually need a KIP for that?) It just seems weird to force the tradeoff onto users of IQ > Remove deprecated methods on WindowStore > > > Key: KAFKA-10434 > URL: https://issues.apache.org/jira/browse/KAFKA-10434 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jorge Esteban Quilcate Otoya >Priority: Major > > From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and > [https://github.com/apache/kafka/pull/9138#discussion_r474995606] : > WindowStore contains ReadOnlyWindowStore methods. > We could consider: > * Moving read methods from WindowStore to ReadOnlyWindowStore and/or > * Consider removing long based methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore
[
https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184778#comment-17184778
]
Sophie Blee-Goldman commented on KAFKA-10434:
-
Gotcha. Then can we at least put this explanation in the comments, the current
{code:java}
// note, this method must be kept if super#fetch(...) is removed
{code}
comments are not particularly illuminating.
[~jeqo] I guess we would indeed want to use the `long` version of the signature
for the underlying store in the reverse iterator PR (and add them to the
WindowStore API).
Thanks for clarifying [~mjsax]
> Remove deprecated methods on WindowStore
>
>
> Key: KAFKA-10434
> URL: https://issues.apache.org/jira/browse/KAFKA-10434
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Jorge Esteban Quilcate Otoya
>Priority: Major
>
> From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and
> [https://github.com/apache/kafka/pull/9138#discussion_r474995606] :
> WindowStore contains ReadOnlyWindowStore methods.
> We could consider:
> * Moving read methods from WindowStore to ReadOnlyWindowStore and/or
> * Consider removing long based methods
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184776#comment-17184776 ] Matthias J. Sax commented on KAFKA-10434: - We want to keep those methods as discussed on the KIP for perf reasons. Only for the "ReadOnly" stores that are used for IQ, we want to have the methods using `Instant` and `Duration` as they provide a better API. However, for the "read-write" interfaces we want to have the more performant `long` variants to avoid unnecessary (shorted lived) object creation. Atm, we inherit the `long` variants from the read-only-interface. However, when we remove those methods from the read-only interface, we need to declare them on the "read-write" interface. The original PR did this "preparation" already by "re-declaring" the methods (that is kinda redundant atm, however allows us to mark the methods as "not deprecated" in the "read-write" classes). Hence, we don't mark those methods as `@Deprecated` as we don't intent to remove them, but we need to suppress the deprecation warning as long as we inherit the methods from the read-only interfaces. I think we should close this ticket as "invalid". \cc [~ableegoldman] > Remove deprecated methods on WindowStore > > > Key: KAFKA-10434 > URL: https://issues.apache.org/jira/browse/KAFKA-10434 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jorge Esteban Quilcate Otoya >Priority: Major > > From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and > [https://github.com/apache/kafka/pull/9138#discussion_r474995606] : > WindowStore contains ReadOnlyWindowStore methods. > We could consider: > * Moving read methods from WindowStore to ReadOnlyWindowStore and/or > * Consider removing long based methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
