[jira] [Commented] (KAFKA-10594) Enhance Raft exception handling

2021-05-16 Thread Guozhang Wang (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345868#comment-17345868
 ] 

Guozhang Wang commented on KAFKA-10594:
---

Thanks for filing this Boyang. I also agree with [~jagsancio] that we need to 
fix scenarios where an internal thread may die silently.

> Enhance Raft exception handling
> ---
>
> Key: KAFKA-10594
> URL: https://issues.apache.org/jira/browse/KAFKA-10594
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Boyang Chen
>Priority: Major
>
> The current exception handling on the Raft implementation is superficial, for 
> example we don't treat file system exception and request handling exception 
> differently. It's necessary to decide what kind of exception should be fatal, 
> what kind of exception should be responding to the client, and what exception 
> could be retried.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10594) Enhance Raft exception handling

2021-05-13 Thread Boyang Chen (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344088#comment-17344088
 ] 

Boyang Chen commented on KAFKA-10594:
-

That's correct, thanks! [~jagsancio]

> Enhance Raft exception handling
> ---
>
> Key: KAFKA-10594
> URL: https://issues.apache.org/jira/browse/KAFKA-10594
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Boyang Chen
>Priority: Major
>
> The current exception handling on the Raft implementation is superficial, for 
> example we don't treat file system exception and request handling exception 
> differently. It's necessary to decide what kind of exception should be fatal, 
> what kind of exception should be responding to the client, and what exception 
> could be retried.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-10594) Enhance Raft exception handling

2021-05-13 Thread Jose Armando Garcia Sancio (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344032#comment-17344032
 ] 

Jose Armando Garcia Sancio commented on KAFKA-10594:


I agree with this. There is also an issue that if the RaftManager thread which 
polls the KafkaRaftClient terminates the broker or controller doesn't 
terminate. I think need to revisit this.

[~bchen225242] I assume you are not working on this at the moment. I am going 
to unassigned the issue. Please re-assign it if you are working on this.

> Enhance Raft exception handling
> ---
>
> Key: KAFKA-10594
> URL: https://issues.apache.org/jira/browse/KAFKA-10594
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Boyang Chen
>Assignee: Boyang Chen
>Priority: Major
>
> The current exception handling on the Raft implementation is superficial, for 
> example we don't treat file system exception and request handling exception 
> differently. It's necessary to decide what kind of exception should be fatal, 
> what kind of exception should be responding to the client, and what exception 
> could be retried.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)