[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521834#comment-17521834 ] Gilles Philippart commented on KAFKA-10733: --- Sorry to chase this again, but can we get a revised ETA for this issue? > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement > Components: producer , streams >Affects Versions: 2.5.0, 2.6.0, 2.7.0 >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492632#comment-17492632 ] Gilles Philippart commented on KAFKA-10733: --- Is there any progress on this ticket? We have several cases per week of InvalidPidMappingException in prod, causing a restart of the apps. > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement > Components: producer , streams >Affects Versions: 2.5.0, 2.6.0, 2.7.0 >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437335#comment-17437335 ] David Jacot commented on KAFKA-10733: - Moved the target release to the next one. > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement > Components: producer , streams >Affects Versions: 2.5.0, 2.6.0, 2.7.0 >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > Fix For: 3.2.0 > > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429856#comment-17429856 ] David Jacot commented on KAFKA-10733: - [~bchen225242] Do we plan to get this on in 3.1.0? It seems that nobody works on it. > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement > Components: producer , streams >Affects Versions: 2.5.0, 2.6.0, 2.7.0 >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > Fix For: 3.1.0 > > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377611#comment-17377611 ] Konstantine Karantasis commented on KAFKA-10733: Thanks for the update [~bchen225242]. Moved the target release to the next one. > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement > Components: producer , streams >Affects Versions: 2.5.0, 2.6.0, 2.7.0 >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > Fix For: 3.1.0 > > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17361932#comment-17361932 ] Boyang Chen commented on KAFKA-10733: - Hey [~kkonstantine] I don't think anyone has cycles to push this to 3.0, we should consider moving it to future releases, cc [~guozhang] [~mjsax] > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement > Components: producer , streams >Affects Versions: 2.5.0, 2.6.0, 2.7.0 >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > Fix For: 3.0.0 > > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237765#comment-17237765 ] Boyang Chen commented on KAFKA-10733: - Also we should understand why we see a trend of seeing more InvalidPid error since 2.5 > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs
[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237764#comment-17237764 ] Boyang Chen commented on KAFKA-10733: - Several agreements being made on offline sync: 1. We should catch certain fatal exceptions and throw task migrated, such as ProducerFenced 2. We should have a new producer exception type to wrap all non-fatal exception to let user catch them and throw as task corrupted 3. We should still crash the stream thread for certain fatal exceptions, such as AuthorizationException > Enforce exception thrown for KafkaProducer txn APIs > --- > > Key: KAFKA-10733 > URL: https://issues.apache.org/jira/browse/KAFKA-10733 > Project: Kafka > Issue Type: Improvement >Reporter: Boyang Chen >Priority: Major > Labels: need-kip > > In general, KafkaProducer could throw both fatal and non-fatal errors as > KafkaException, which makes the exception catching hard. Furthermore, not > every single fatal exception (checked) is marked on the function signature > yet as of 2.7. > We should have a general supporting strategy in long term for this matter, as > whether to declare all non-fatal exceptions as wrapped KafkaException while > extracting all fatal ones, or just add a flag to KafkaException indicating > fatal or not, to maintain binary compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
