[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-07-12 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379486#comment-17379486
 ] 

ASF GitHub Bot commented on KAFKA-12993:


ableegoldman merged pull request #361:
URL: https://github.com/apache/kafka-site/pull/361


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-26 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369915#comment-17369915
 ] 

ASF GitHub Bot commented on KAFKA-12993:


izzyacademy commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-869027105


   > Gotcha, thanks for checking. Can you try setting up a local Apache server 
to test these changes (see instructions 
[here](https://cwiki.apache.org/confluence/display/KAFKA/Setup+Kafka+Website+on+Local+Apache+Server))?
   
   @ableegoldman this is great to know. I was not aware of this before now. 
@showuon I will review it on Monday and share my feedback as well. I am looking 
to contribute documentation changes myself as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-26 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369851#comment-17369851
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868980516


   @ableegoldman , I've updated and confirmed the change can fix the formatting 
issue.
   
![image](https://user-images.githubusercontent.com/43372967/123509883-b38bcc80-d6aa-11eb-8f98-a6e5b2d98e45.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-26 Thread Josep Prat (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369843#comment-17369843
 ] 

Josep Prat commented on KAFKA-12993:


Not about the same page, but I have a couple of PRs still open fixing code 
listings on different pages, in case you find them relevant:
 * [https://github.com/apache/kafka/pull/10769]
 * [https://github.com/apache/kafka/pull/10768]
 * [https://github.com/apache/kafka/pull/10767]

 

> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-26 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369834#comment-17369834
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868968278


   Will do and let you know. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369794#comment-17369794
 ] 

ASF GitHub Bot commented on KAFKA-12993:


ableegoldman commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868940746


   Gotcha, thanks for checking. Can you try setting up a local Apache server to 
test these changes (see instructions 
[here](https://cwiki.apache.org/confluence/display/KAFKA/Setup+Kafka+Website+on+Local+Apache+Server))?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369781#comment-17369781
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon commented on a change in pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#discussion_r659103580



##
File path: 27/streams/developer-guide/memory-mgmt.html
##
@@ -168,7 +168,7 @@
   RocksDB
Each instance of RocksDB allocates off-heap memory for a block 
cache, index and filter blocks, and memtable (write buffer). Critical configs 
(for RocksDB version 4.1.0) include
 block_cache_size, write_buffer_size and max_write_buffer_number.  These can be specified 
through the
-rocksdb.config.setter configuration.
+rocksdb.config.setter configuration.

Review comment:
   add missing `` tag




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369782#comment-17369782
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868926930


   @ableegoldman , I've checked, the line 165 for `` change is to fix 
the new added doc in this PR https://github.com/apache/kafka/pull/10046, not 
existed in V2.8. I also added a missing `` tag. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread A. Sophie Blee-Goldman (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369758#comment-17369758
 ] 

A. Sophie Blee-Goldman commented on KAFKA-12993:


Oh, you already have a PR for kafka-site. I should have known :P

> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369757#comment-17369757
 ] 

ASF GitHub Bot commented on KAFKA-12993:


ableegoldman commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868882876


   @cadonna this PR is just porting  #10651 over to kafka-site, right? I agree 
that the basic formatting fix for the memory management docs at least should be 
ported to the live site ASAP.
   
   @showuon is there also a missing `` tag? See [line 
165](https://github.com/apache/kafka/pull/10651/files#diff-90f13939de7269a2ab9e8d0e8596f29afd1f4293710319fdcde35d84bca5c195R165)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread A. Sophie Blee-Goldman (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369756#comment-17369756
 ] 

A. Sophie Blee-Goldman commented on KAFKA-12993:


Ah, I didn't realize this was already addressed. Thanks for the heads up Bruno. 
I agree with Luke's take on this: not every docs change needs to go into 
kafka-site right away, but for something like this which is a pretty egregious 
formatting issue that makes it very difficult to read, we should fix it on the 
live site ASAP.

[~showuon] do you want to port this PR over to kafka-site?

> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Luke Chen (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369459#comment-17369459
 ] 

Luke Chen commented on KAFKA-12993:
---

[~cadonna], yes, I know this is been done by 
[https://github.com/apache/kafka/pull/10651] as mentioned in my PR. But that 
needs to wait next release to fix it. We can make the same change in PR:10651 
into Kafka-site repo, or we can just pick my quick fix to add the closing `pre` 
tag.

 

I don't think we should make every change to docs into Kafka and Kafka-site 
repo, especially, there are some new docs for new released feature. But in this 
case, it's like a bug to the doc in current release, it should be fixed in both 
repo.

 

Thank you.

> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread Bruno Cadonna (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369454#comment-17369454
 ] 

Bruno Cadonna commented on KAFKA-12993:
---

I thinkthis has already been done by 
https://github.com/apache/kafka/pull/10651. With the next release it should be 
also merged to kafka-site. 
I am not sure about the process here. Should every PR against docs in kafka 
also be made against kafka-site? \cc [~ableegoldman] [~mjsax] 

> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369452#comment-17369452
 ] 

ASF GitHub Bot commented on KAFKA-12993:


cadonna commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868481708


   @showuon I think this has been already done in PR #10651.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369302#comment-17369302
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon commented on pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#issuecomment-868286033


   @ableegoldman , please take a look. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369301#comment-17369301
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon commented on a change in pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#discussion_r658532684



##
File path: 27/streams/developer-guide/memory-mgmt.html
##
@@ -179,7 +179,7 @@ RocksDB@Override
public void setConfig(final String storeName, final Options options, final 
MapString, Object configs) {
 
- BlockBasedTableConfig tableConfig = (BlockBasedTableConfig) options.tableFormatConfig();
+ BlockBasedTableConfig tableConfig = (BlockBasedTableConfig) options.tableFormatConfig();

Review comment:
   fix 2: remove redundant `span` tag

##
File path: 27/streams/developer-guide/memory-mgmt.html
##
@@ -201,6 +201,7 @@ RocksDB// Cache and WriteBufferManager should not be closed 
here, as the same objects are shared by every store instance.
}
 }
+

Review comment:
   fix 1: add missing `pre` tag

##
File path: 27/streams/developer-guide/memory-mgmt.html
##
@@ -217,6 +218,7 @@ RocksDBhttps://github.com/facebook/rocksdb/wiki/Partitioned-Index-Filters;>RocksDB
 docs.
 
   
+

Review comment:
   add missing `sup` tag




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-25 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369300#comment-17369300
 ] 

ASF GitHub Bot commented on KAFKA-12993:


showuon opened a new pull request #361:
URL: https://github.com/apache/kafka-site/pull/361


   1. add missing closing tag
   2. remove a redundant `span` tag


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-12993) Formatting of Streams 'Memory Management' docs is messed up

2021-06-24 Thread Luke Chen (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369200#comment-17369200
 ] 

Luke Chen commented on KAFKA-12993:
---

on it~

> Formatting of Streams 'Memory Management' docs is messed up 
> 
>
> Key: KAFKA-12993
> URL: https://issues.apache.org/jira/browse/KAFKA-12993
> Project: Kafka
>  Issue Type: Bug
>  Components: docs, streams
>Reporter: A. Sophie Blee-Goldman
>Assignee: Luke Chen
>Priority: Blocker
> Fix For: 3.0.0, 2.8.1
>
>
> The formatting of this page is all messed up, starting in the RocksDB 
> section. It looks like there's a missing closing tag after the example 
> BoundedMemoryRocksDBConfig class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)