[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding
[
https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392626#comment-17392626
]
Luke Chen commented on KAFKA-13145:
---
I'm good. I'll close this ticket and add `SlidingWindow` class via KAKFA-12839.
Thank you.
> Renaming the time interval window for better understanding
> --
>
> Key: KAFKA-13145
> URL: https://issues.apache.org/jira/browse/KAFKA-13145
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Luke Chen
>Assignee: Luke Chen
>Priority: Major
>
>
> I have another thought, which is to rename the time interval related windows.
> Currently, we have 3 types of time interval window:
> {{TimeWindow}} -> to have {{[start,end)}} time interval
> {{SessionWindow}} -> to have {{[start,end]}} time interval
> {{UnlimitedWindow}} -> to have {{[start, MAX_VALUE)}} time interval
> I think the name {{SessionWindow}} is definitely not good here, especially we
> want to use it in {{SlidingWindows}} now, although it is only used for
> {{SessionWindows}} before. We should name them with time interval meaning,
> not the streaming window functions meaning. {{}}Because these 3 window types
> are internal use only, it is safe to rename them.
>
> {{TimeWindow}} --> {{InclusiveExclusiveWindow}}
> {{SessionWindow}} / {{SlidingWindow}} --> {{InclusiveInclusiveWindow}}
> {{UnlimitedWindow}} --> {{InclusiveUnboundedWindow}}
> {{}}
> See the discussion here{{:
> [https://github.com/apache/kafka/pull/11124#issuecomment-887989639]}}
> {{}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding
[
https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392615#comment-17392615
]
A. Sophie Blee-Goldman commented on KAFKA-13145:
Fine with me. FWIW the "InclusiveExclusiveWindow" name was my idea, but that
was just to avoid using something called "SessionWindow" in the _Sliding_
window processor – making a new SlidingWindow class works too.
> Renaming the time interval window for better understanding
> --
>
> Key: KAFKA-13145
> URL: https://issues.apache.org/jira/browse/KAFKA-13145
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Luke Chen
>Assignee: Luke Chen
>Priority: Major
>
>
> I have another thought, which is to rename the time interval related windows.
> Currently, we have 3 types of time interval window:
> {{TimeWindow}} -> to have {{[start,end)}} time interval
> {{SessionWindow}} -> to have {{[start,end]}} time interval
> {{UnlimitedWindow}} -> to have {{[start, MAX_VALUE)}} time interval
> I think the name {{SessionWindow}} is definitely not good here, especially we
> want to use it in {{SlidingWindows}} now, although it is only used for
> {{SessionWindows}} before. We should name them with time interval meaning,
> not the streaming window functions meaning. {{}}Because these 3 window types
> are internal use only, it is safe to rename them.
>
> {{TimeWindow}} --> {{InclusiveExclusiveWindow}}
> {{SessionWindow}} / {{SlidingWindow}} --> {{InclusiveInclusiveWindow}}
> {{UnlimitedWindow}} --> {{InclusiveUnboundedWindow}}
> {{}}
> See the discussion here{{:
> [https://github.com/apache/kafka/pull/11124#issuecomment-887989639]}}
> {{}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding
[
https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17392611#comment-17392611
]
Matthias J. Sax commented on KAFKA-13145:
-
Personally, I am not a fan on `InclusiveExclusiveWindow` as a name, but if you
feel strong about it, I can be convinced. Because the window classes in
question are small an easy, I would rather prefer to just duplicate the code if
necessary, and keep the semantically more meaningful names that we have now.
Ie, we would just add a `SlidingWindow` (that also has inclusive upper/lower
bound, similar to `SessionWindow`) and call it a day. – Because the code is so
simple, I am not worried about code duplication personally.
For this case, we could close this ticket as "won't fix" and just add
`SlidingWindow` class via KAKFA-12839 instead. Thoughts? \cc [~ableegoldman]
> Renaming the time interval window for better understanding
> --
>
> Key: KAFKA-13145
> URL: https://issues.apache.org/jira/browse/KAFKA-13145
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Luke Chen
>Assignee: Luke Chen
>Priority: Major
>
>
> I have another thought, which is to rename the time interval related windows.
> Currently, we have 3 types of time interval window:
> {{TimeWindow}} -> to have {{[start,end)}} time interval
> {{SessionWindow}} -> to have {{[start,end]}} time interval
> {{UnlimitedWindow}} -> to have {{[start, MAX_VALUE)}} time interval
> I think the name {{SessionWindow}} is definitely not good here, especially we
> want to use it in {{SlidingWindows}} now, although it is only used for
> {{SessionWindows}} before. We should name them with time interval meaning,
> not the streaming window functions meaning. {{}}Because these 3 window types
> are internal use only, it is safe to rename them.
>
> {{TimeWindow}} --> {{InclusiveExclusiveWindow}}
> {{SessionWindow}} / {{SlidingWindow}} --> {{InclusiveInclusiveWindow}}
> {{UnlimitedWindow}} --> {{InclusiveUnboundedWindow}}
> {{}}
> See the discussion here{{:
> [https://github.com/apache/kafka/pull/11124#issuecomment-887989639]}}
> {{}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
