[jira] [Commented] (KAFKA-14974) Restore backward compatibility in KafkaBasedLog
[
https://issues.apache.org/jira/browse/KAFKA-14974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720566#comment-17720566
]
Yash Mayya commented on KAFKA-14974:
Thanks [~rhauch], your understanding here is correct. We should backport [this
fix|https://github.com/apache/kafka/pull/13688] to {{{}3.3{}}}, {{3.4}} and
{{3.5}} as well (before the {{3.5.0}} release ideally, if possible).
> Restore backward compatibility in KafkaBasedLog
> ---
>
> Key: KAFKA-14974
> URL: https://issues.apache.org/jira/browse/KAFKA-14974
> Project: Kafka
> Issue Type: Task
> Components: KafkaConnect
>Affects Versions: 3.5.0, 3.4.1, 3.3.3
>Reporter: Yash Mayya
>Assignee: Yash Mayya
>Priority: Major
>
> {{KafkaBasedLog}} is a widely used utility class that provides a generic
> implementation of a shared, compacted log of records in a Kafka topic. It
> isn't in Connect's public API, but has been used outside of Connect and we
> try to preserve backward compatibility whenever possible.
> https://issues.apache.org/jira/browse/KAFKA-14455 modified the two overloaded
> void {{KafkaBasedLog::send}} methods to return a {{{}Future{}}}. While this
> change is source compatible, it isn't binary compatible. We can restore
> backward compatibility simply by re-instating the older send methods, and
> renaming the new Future returning send methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-14974) Restore backward compatibility in KafkaBasedLog
[
https://issues.apache.org/jira/browse/KAFKA-14974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720553#comment-17720553
]
Randall Hauch commented on KAFKA-14974:
---
[~yash.mayya], just to clarify:
# #12984 changed the signatures of the then-`send(...)` methods by adding a
return, which breaks backward compatibility for this utility class.
# Those changes were made on `trunk` prior to the `3.5` branch ([it's in the
`3.5`
history](https://github.com/apache/kafka/commits/3.5?after=f9730c11b7b48a37f527a363e0c6dced53fdbc69+314=3.5_name=refs%2Fheads%2F3.5)),
and backported to the `3.4` and `3.3` branches
# To restore backward compatibility, this PR renames those methods that return
a `Future` as `sendWithReceipt(...)` and adds back the two `send(...)` methods
that have the same signature as before
Is this correct?
> Restore backward compatibility in KafkaBasedLog
> ---
>
> Key: KAFKA-14974
> URL: https://issues.apache.org/jira/browse/KAFKA-14974
> Project: Kafka
> Issue Type: Task
> Components: KafkaConnect
>Affects Versions: 3.5.0, 3.4.1, 3.3.3
>Reporter: Yash Mayya
>Assignee: Yash Mayya
>Priority: Major
>
> {{KafkaBasedLog}} is a widely used utility class that provides a generic
> implementation of a shared, compacted log of records in a Kafka topic. It
> isn't in Connect's public API, but has been used outside of Connect and we
> try to preserve backward compatibility whenever possible.
> https://issues.apache.org/jira/browse/KAFKA-14455 modified the two overloaded
> void {{KafkaBasedLog::send}} methods to return a {{{}Future{}}}. While this
> change is source compatible, it isn't binary compatible. We can restore
> backward compatibility simply by re-instating the older send methods, and
> renaming the new Future returning send methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-14974) Restore backward compatibility in KafkaBasedLog
[
https://issues.apache.org/jira/browse/KAFKA-14974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720546#comment-17720546
]
Randall Hauch commented on KAFKA-14974:
---
Thanks for catching this and providing a fix. Indeed, we have tried to maintain
backward compatibility for this class since it is super useful.
> Restore backward compatibility in KafkaBasedLog
> ---
>
> Key: KAFKA-14974
> URL: https://issues.apache.org/jira/browse/KAFKA-14974
> Project: Kafka
> Issue Type: Task
>Reporter: Yash Mayya
>Assignee: Yash Mayya
>Priority: Major
>
> {{KafkaBasedLog}} is a widely used utility class that provides a generic
> implementation of a shared, compacted log of records in a Kafka topic. It
> isn't in Connect's public API, but has been used outside of Connect and we
> try to preserve backward compatibility whenever possible.
> https://issues.apache.org/jira/browse/KAFKA-14455 modified the two overloaded
> void {{KafkaBasedLog::send}} methods to return a {{{}Future{}}}. While this
> change is source compatible, it isn't binary compatible. We can restore
> backward compatibility simply by re-instating the older send methods, and
> renaming the new Future returning send methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
