[jira] [Commented] (KAFKA-16473) KafkaDockerWrapper uses wrong cluster ID when formatting log dir
[ https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834021#comment-17834021 ] Sebastian Marsching commented on KAFKA-16473: - [~brandboat] The PR is now available at [https://github.com/apache/kafka/pull/15658]. > KafkaDockerWrapper uses wrong cluster ID when formatting log dir > > > Key: KAFKA-16473 > URL: https://issues.apache.org/jira/browse/KAFKA-16473 > Project: Kafka > Issue Type: Bug >Affects Versions: 3.7.0 >Reporter: Sebastian Marsching >Priority: Major > > There is a bug in {{{}KafkaDockerWrapper{}}}, that causes {{Some( CLUSTER_ID environment variable>)}} to be used when formatting the log dir > when Kafka is started for the first time inside a Docker container. > More specifically, the problem is in {{{}formatStorageCmd{}}}: The code uses > {{{}env.get("CLUSTER_ID"){}}}, but this returns an {{Option}} not a > {{{}String{}}}. > The code should instead check whether the environment variable is set, > raising an exception if it is not set. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16473) KafkaDockerWrapper uses wrong cluster ID when formatting log dir
[ https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834001#comment-17834001 ] Kuan Po Tseng commented on KAFKA-16473: --- > I would appreciate a review of that PR, though. Sure, I'll do that. Thanks for your input! > KafkaDockerWrapper uses wrong cluster ID when formatting log dir > > > Key: KAFKA-16473 > URL: https://issues.apache.org/jira/browse/KAFKA-16473 > Project: Kafka > Issue Type: Bug >Affects Versions: 3.7.0 >Reporter: Sebastian Marsching >Priority: Major > > There is a bug in {{{}KafkaDockerWrapper{}}}, that causes {{Some( CLUSTER_ID environment variable>)}} to be used when formatting the log dir > when Kafka is started for the first time inside a Docker container. > More specifically, the problem is in {{{}formatStorageCmd{}}}: The code uses > {{{}env.get("CLUSTER_ID"){}}}, but this returns an {{Option}} not a > {{{}String{}}}. > The code should instead check whether the environment variable is set, > raising an exception if it is not set. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16473) KafkaDockerWrapper uses wrong cluster ID when formatting log dir
[ https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833999#comment-17833999 ] Sebastian Marsching commented on KAFKA-16473: - I am currently working on a PR that should address this issue. I would appreciate a review of that PR, though. > KafkaDockerWrapper uses wrong cluster ID when formatting log dir > > > Key: KAFKA-16473 > URL: https://issues.apache.org/jira/browse/KAFKA-16473 > Project: Kafka > Issue Type: Bug >Affects Versions: 3.7.0 >Reporter: Sebastian Marsching >Priority: Major > > There is a bug in {{{}KafkaDockerWrapper{}}}, that causes {{Some( CLUSTER_ID environment variable>)}} to be used when formatting the log dir > when Kafka is started for the first time inside a Docker container. > More specifically, the problem is in {{{}formatStorageCmd{}}}: The code uses > {{{}env.get("CLUSTER_ID"){}}}, but this returns an {{Option}} not a > {{{}String{}}}. > The code should instead check whether the environment variable is set, > raising an exception if it is not set. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-16473) KafkaDockerWrapper uses wrong cluster ID when formatting log dir
[ https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833997#comment-17833997 ] Kuan Po Tseng commented on KAFKA-16473: --- Thank you for the detailed description. Are you planning to address this issue? If not, I'd be happy to take care of it. > KafkaDockerWrapper uses wrong cluster ID when formatting log dir > > > Key: KAFKA-16473 > URL: https://issues.apache.org/jira/browse/KAFKA-16473 > Project: Kafka > Issue Type: Bug >Affects Versions: 3.7.0 >Reporter: Sebastian Marsching >Priority: Major > > There is a bug in {{{}KafkaDockerWrapper{}}}, that causes {{Some( CLUSTER_ID environment variable>)}} to be used when formatting the log dir > when Kafka is started for the first time inside a Docker container. > More specifically, the problem is in {{{}formatStorageCmd{}}}: The code uses > {{{}env.get("CLUSTER_ID"){}}}, but this returns an {{Option}} not a > {{{}String{}}}. > The code should instead check whether the environment variable is set, > raising an exception if it is not set. -- This message was sent by Atlassian Jira (v8.20.10#820010)