[jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191211#comment-16191211
 ] 

ASF GitHub Bot commented on KAFKA-5738:
---

GitHub user rajinisivaram opened a pull request:

https://github.com/apache/kafka/pull/4014

KAFKA-5738: Upgrade note for cumulative count metric (KIP-187)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rajinisivaram/kafka MINOR-upgrade-KIP-187

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4014


commit 146a05fce547c559602799b81188793ed749d7a8
Author: Rajini Sivaram 
Date:   2017-10-04T12:54:46Z

KAFKA-5738: Upgrade note for cumulative count metric (KIP-187)




> Add cumulative count attribute for all Kafka rate metrics
> -
>
> Key: KAFKA-5738
> URL: https://issues.apache.org/jira/browse/KAFKA-5738
> Project: Kafka
>  Issue Type: New Feature
>  Components: metrics
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
> Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream 
> processing simpler, more accurate, and more flexible.
>  
> See 
> [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
>  for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics

[Rajini Sivaram (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169338#comment-16169338
 ] 

Rajini Sivaram commented on KAFKA-5738:
---

[~wushujames] Thank you for reporting this. I will submit a PR since I broke 
it. Perhaps you could review the PR.
[~ijuma] It looks like the metrics are created using the templates, but the 
list used to autogenerate docs needs to be manually populated since it is not 
required when not generating docs. Adding a unit test to avoid this issue in 
future.

> Add cumulative count attribute for all Kafka rate metrics
> -
>
> Key: KAFKA-5738
> URL: https://issues.apache.org/jira/browse/KAFKA-5738
> Project: Kafka
>  Issue Type: New Feature
>  Components: metrics
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
> Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream 
> processing simpler, more accurate, and more flexible.
>  
> See 
> [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
>  for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics

[Ismael Juma (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169235#comment-16169235
 ] 

Ismael Juma commented on KAFKA-5738:


Please submit a PR [~wushujames], if you have the time. To avoid such issues, 
we could write a test that compares the templates with the actual metrics. 
And/or we could always use the templates to create actual metrics.

> Add cumulative count attribute for all Kafka rate metrics
> -
>
> Key: KAFKA-5738
> URL: https://issues.apache.org/jira/browse/KAFKA-5738
> Project: Kafka
>  Issue Type: New Feature
>  Components: metrics
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
> Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream 
> processing simpler, more accurate, and more flexible.
>  
> See 
> [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
>  for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics

[James Cheng (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169222#comment-16169222
 ] 

James Cheng commented on KAFKA-5738:


The PR for this forgot to add the new Sender metrics to getAllTemplates() 
method, which means we won't have autogenerated docs for those metrics. 
https://github.com/apache/kafka/blame/8a5e86660593eab49c64fdfb5ef090634ae5ae06/clients/src/main/java/org/apache/kafka/clients/producer/internals/SenderMetricsRegistry.java#L111

It's an easy mistake to make, since there is unfortunately no automatic way to 
keep that list in sync with the actual metrics.

Should I submit a PR to add those in? Or [~rsivaram], would you like to do it?

> Add cumulative count attribute for all Kafka rate metrics
> -
>
> Key: KAFKA-5738
> URL: https://issues.apache.org/jira/browse/KAFKA-5738
> Project: Kafka
>  Issue Type: New Feature
>  Components: metrics
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
> Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream 
> processing simpler, more accurate, and more flexible.
>  
> See 
> [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
>  for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167096#comment-16167096
 ] 

ASF GitHub Bot commented on KAFKA-5738:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3686


> Add cumulative count attribute for all Kafka rate metrics
> -
>
> Key: KAFKA-5738
> URL: https://issues.apache.org/jira/browse/KAFKA-5738
> Project: Kafka
>  Issue Type: New Feature
>  Components: metrics
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
> Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream 
> processing simpler, more accurate, and more flexible.
>  
> See 
> [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
>  for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130249#comment-16130249
 ] 

ASF GitHub Bot commented on KAFKA-5738:
---

GitHub user rajinisivaram opened a pull request:

https://github.com/apache/kafka/pull/3686

[WIP] KAFKA-5738: Add cumulative count for rate metrics

Implementation of 
https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rajinisivaram/kafka KAFKA-5738

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3686






> Add cumulative count attribute for all Kafka rate metrics
> -
>
> Key: KAFKA-5738
> URL: https://issues.apache.org/jira/browse/KAFKA-5738
> Project: Kafka
>  Issue Type: New Feature
>  Components: metrics
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
> Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream 
> processing simpler, more accurate, and more flexible.
>  
> See 
> [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
>  for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)