[ 
https://issues.apache.org/jira/browse/KAFKA-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168750#comment-16168750
 ] 

James Cheng commented on KAFKA-5906:
------------------------------------

I believe these are public APIs (the config keys, as well as the 
interfaces/classes) and therefore would require a KIP before being able to 
change them.

Fixing the docs, though, is doable without a KIP. Good catch!

> Change metric.reporters configuration key to metrics.reporters to be 
> consistent
> -------------------------------------------------------------------------------
>
>                 Key: KAFKA-5906
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5906
>             Project: Kafka
>          Issue Type: Improvement
>          Components: config, metrics
>            Reporter: Kevin Lu
>            Priority: Minor
>              Labels: usability
>
> The "metric.reporters" configuration key should be consistent with the actual 
> classes. Clients have a MetricsReporter.class while the broker has a 
> KafkaMetricsReporter.class. 
> We have seen quite a few people configure this field incorrectly by setting 
> it as "metrics.reporters".
> The configuration key could be renamed to "metrics.reporters" to match the 
> classes, or the classes can be renamed to MetricReporter.class and 
> KafkaMetricReporter.class.
> The broker configuration description for "metric.reporters" also mentions 
> MetricReporter, but KafkaMetricsReporter is the actual interface to 
> implement. 
> There also seems to be a discrepancy with "MetricReporter" in the description 
> as the class name is actually "MetricsReporter". 
> https://github.com/apache/kafka/pull/3867



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to