[jira] [Commented] (KAFKA-6515) Add toString() method to kafka connect Field class

2018-02-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351530#comment-16351530
 ] 

ASF GitHub Bot commented on KAFKA-6515:
---

hachikuji closed pull request #4509: KAFKA-6515 Adding toString() method to 
o.a.k.connect.data.Field
URL: https://github.com/apache/kafka/pull/4509
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/connect/api/src/main/java/org/apache/kafka/connect/data/Field.java 
b/connect/api/src/main/java/org/apache/kafka/connect/data/Field.java
index 3a8df17a910..b5d3f027968 100644
--- a/connect/api/src/main/java/org/apache/kafka/connect/data/Field.java
+++ b/connect/api/src/main/java/org/apache/kafka/connect/data/Field.java
@@ -73,4 +73,13 @@ public boolean equals(Object o) {
 public int hashCode() {
 return Objects.hash(name, index, schema);
 }
+
+@Override
+public String toString() {
+return "Field{" +
+"name=" + name +
+", index=" + index +
+", schema=" + schema +
+"}";
+}
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add toString() method to kafka connect Field class
> --
>
> Key: KAFKA-6515
> URL: https://issues.apache.org/jira/browse/KAFKA-6515
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Reporter: Bartłomiej Tartanus
>Priority: Minor
> Fix For: 1.2.0
>
>
> Currently testing is really painful:
> {code:java}
> org.apache.kafka.connect.data.Field@1d51df1f was not equal to 
> org.apache.kafka.connect.data.Field@c0d62cd8{code}
>  
> toString() method would fix this, so please add one. :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KAFKA-6515) Add toString() method to kafka connect Field class

2018-02-01 Thread Gunnar Morling (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349389#comment-16349389
 ] 

Gunnar Morling commented on KAFKA-6515:
---

Filed a PR as shown above, but can't transition this to "Patch available" due 
to lack of permissions I reckon.

> Add toString() method to kafka connect Field class
> --
>
> Key: KAFKA-6515
> URL: https://issues.apache.org/jira/browse/KAFKA-6515
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Reporter: Bartłomiej Tartanus
>Priority: Minor
>
> Currently testing is really painful:
> {code:java}
> org.apache.kafka.connect.data.Field@1d51df1f was not equal to 
> org.apache.kafka.connect.data.Field@c0d62cd8{code}
>  
> toString() method would fix this, so please add one. :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KAFKA-6515) Add toString() method to kafka connect Field class

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349386#comment-16349386
 ] 

ASF GitHub Bot commented on KAFKA-6515:
---

gunnarmorling opened a new pull request #4509: KAFKA-6515 Adding toString() 
method to o.a.k.connect.data.Field
URL: https://github.com/apache/kafka/pull/4509
 
 
   https://issues.apache.org/jira/browse/KAFKA-6515
   
   ### Committer Checklist (excluded from commit message)
   - [x] Verify design and implementation 
   - [x] Verify test coverage and CI build status
   - [x] Verify documentation (including upgrade notes)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add toString() method to kafka connect Field class
> --
>
> Key: KAFKA-6515
> URL: https://issues.apache.org/jira/browse/KAFKA-6515
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Reporter: Bartłomiej Tartanus
>Priority: Minor
>
> Currently testing is really painful:
> {code:java}
> org.apache.kafka.connect.data.Field@1d51df1f was not equal to 
> org.apache.kafka.connect.data.Field@c0d62cd8{code}
>  
> toString() method would fix this, so please add one. :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)