[jira] [Commented] (KAFKA-6786) Remove additional configs in StreamsStandbyTask

2018-05-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461557#comment-16461557
 ] 

Guozhang Wang commented on KAFKA-6786:
--

Jimin,

Yes that's right. Thanks for pointing out

Abhishek, please feel free to leave comments on this ticket for any problems 
you bump into.

> Remove additional configs in StreamsStandbyTask
> ---
>
> Key: KAFKA-6786
> URL: https://issues.apache.org/jira/browse/KAFKA-6786
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Abhishek Sharma
>Priority: Minor
>  Labels: newbie
>
> Since we are now passing in a property file into the streams service 
> initialization code, we do not need to pass in those configs as additional 
> properties in StreamsStandbyTask. We can refactor this test to get rid of the 
> additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-6786) Remove additional configs in StreamsStandbyTask

2018-04-29 Thread Abhishek Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458263#comment-16458263
 ] 

Abhishek Sharma commented on KAFKA-6786:


Thanks [~mjsax], much appreciated. If I'm facing any issues related to project 
build issues, should I raise them here, or contact the dev mailing list?

> Remove additional configs in StreamsStandbyTask
> ---
>
> Key: KAFKA-6786
> URL: https://issues.apache.org/jira/browse/KAFKA-6786
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Abhishek Sharma
>Priority: Minor
>  Labels: newbie
>
> Since we are now passing in a property file into the streams service 
> initialization code, we do not need to pass in those configs as additional 
> properties in StreamsStandbyTask. We can refactor this test to get rid of the 
> additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-6786) Remove additional configs in StreamsStandbyTask

2018-04-24 Thread Matthias J. Sax (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450057#comment-16450057
 ] 

Matthias J. Sax commented on KAFKA-6786:


Thanks for your interest [~abhi_sh]! I assigned the Jira to you. Also added you 
to the list on contributors. Feel free to assign unassigned Jiras to yourself 
if you want to pick them up.

> Remove additional configs in StreamsStandbyTask
> ---
>
> Key: KAFKA-6786
> URL: https://issues.apache.org/jira/browse/KAFKA-6786
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Abhishek Sharma
>Priority: Minor
>  Labels: newbie
>
> Since we are now passing in a property file into the streams service 
> initialization code, we do not need to pass in those configs as additional 
> properties in StreamsStandbyTask. We can refactor this test to get rid of the 
> additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-6786) Remove additional configs in StreamsStandbyTask

2018-04-22 Thread Abhishek Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447356#comment-16447356
 ] 

Abhishek Sharma commented on KAFKA-6786:


Hi, I'm new to contributing to Kafka, and it would be great if I could pick up 
this issue if it's alright with everyone else?

> Remove additional configs in StreamsStandbyTask
> ---
>
> Key: KAFKA-6786
> URL: https://issues.apache.org/jira/browse/KAFKA-6786
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Reporter: Guozhang Wang
>Priority: Minor
>  Labels: newbie
>
> Since we are now passing in a property file into the streams service 
> initialization code, we do not need to pass in those configs as additional 
> properties in StreamsStandbyTask. We can refactor this test to get rid of the 
> additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-6786) Remove additional configs in StreamsStandbyTask

2018-04-20 Thread Jimin Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446608#comment-16446608
 ] 

Jimin Hsieh commented on KAFKA-6786:


If I don't misunderstand, the actual class should be removed additional congis 
is `StandbyTaskTest`.

> Remove additional configs in StreamsStandbyTask
> ---
>
> Key: KAFKA-6786
> URL: https://issues.apache.org/jira/browse/KAFKA-6786
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Reporter: Guozhang Wang
>Priority: Minor
>  Labels: newbie
>
> Since we are now passing in a property file into the streams service 
> initialization code, we do not need to pass in those configs as additional 
> properties in StreamsStandbyTask. We can refactor this test to get rid of the 
> additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)