[jira] [Commented] (KAFKA-8233) Helper classes to make it simpler to write test logic with TopologyTestDriver
[ https://issues.apache.org/jira/browse/KAFKA-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945660#comment-16945660 ] ASF GitHub Bot commented on KAFKA-8233: --- mjsax commented on pull request #7378: KAFKA-8233: KIP-470: TopologyTestDriver test input and output usability improvements URL: https://github.com/apache/kafka/pull/7378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Helper classes to make it simpler to write test logic with TopologyTestDriver > - > > Key: KAFKA-8233 > URL: https://issues.apache.org/jira/browse/KAFKA-8233 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jukka Karvanen >Assignee: Jukka Karvanen >Priority: Minor > Labels: kip > > When using TopologyTestDriver you need to call ConsumerRecordFactory to > create ConsumerRecord passed into pipeInput method to write to topic. Also > when calling readOutput to consume from topic, you need to provide correct > Deserializers each time. > You easily end up writing helper methods in your test classed, but this can > be avoided when adding generic input and output topic classes. > This improvement adds TestInputTopic class which wraps TopologyTestDriver > and ConsumerRecordFactory methods as one class to be used to write to Input > Topics and TestOutputTopic class which collects TopologyTestDriver reading > methods and provide typesafe read methods. > This is KIP: > [https://cwiki.apache.org/confluence/display/KAFKA/KIP-470%3A+TopologyTestDriver+test+input+and+output+usability+improvements] > > > More info and an example of how Stream test looks after using this classes: > [https://github.com/jukkakarvanen/kafka-streams-test-topics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-8233) Helper classes to make it simpler to write test logic with TopologyTestDriver
[ https://issues.apache.org/jira/browse/KAFKA-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936337#comment-16936337 ] Matthias J. Sax commented on KAFKA-8233: [~jkarvanen] – I added you to the list of contributors and assigned the ticket to you. You can now also self-assign ticket. > Helper classes to make it simpler to write test logic with TopologyTestDriver > - > > Key: KAFKA-8233 > URL: https://issues.apache.org/jira/browse/KAFKA-8233 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jukka Karvanen >Assignee: Jukka Karvanen >Priority: Minor > Labels: kip > > When using TopologyTestDriver you need to call ConsumerRecordFactory to > create ConsumerRecord passed into pipeInput method to write to topic. Also > when calling readOutput to consume from topic, you need to provide correct > Deserializers each time. > You easily end up writing helper methods in your test classed, but this can > be avoided when adding generic input and output topic classes. > This improvement adds TestInputTopic class which wraps TopologyTestDriver > and ConsumerRecordFactory methods as one class to be used to write to Input > Topics and TestOutputTopic class which collects TopologyTestDriver reading > methods and provide typesafe read methods. > This is KIP: > [https://cwiki.apache.org/confluence/display/KAFKA/KIP-470%3A+TopologyTestDriver+test+input+and+output+usability+improvements] > > > More info and an example of how Stream test looks after using this classes: > [https://github.com/jukkakarvanen/kafka-streams-test-topics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-8233) Helper classes to make it simpler to write test logic with TopologyTestDriver
[ https://issues.apache.org/jira/browse/KAFKA-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936322#comment-16936322 ] ASF GitHub Bot commented on KAFKA-8233: --- jukkakarvanen commented on pull request #7378: KAFKA-8233: [WIP] KIP-470: TopologyTestDriver test input and output usability improvements URL: https://github.com/apache/kafka/pull/7378 This is WIP PR for KIP-470: TopologyTestDriver test input and output usability improvements: https://cwiki.apache.org/confluence/display/KAFKA/KIP-470%3A+TopologyTestDriver+test+input+and+output+usability+improvements Implementation mainly done. Still to do: -Check unit test coverage -Update example application -Update documentation ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Helper classes to make it simpler to write test logic with TopologyTestDriver > - > > Key: KAFKA-8233 > URL: https://issues.apache.org/jira/browse/KAFKA-8233 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Jukka Karvanen >Priority: Minor > Labels: needs-kip > > When using TopologyTestDriver you need to call ConsumerRecordFactory to > create ConsumerRecord passed into pipeInput method to write to topic. Also > when calling readOutput to consume from topic, you need to provide correct > Deserializers each time. > You easily end up writing helper methods in your test classed, but this can > be avoided when adding generic input and output topic classes. > This improvement adds TestInputTopic class which wraps TopologyTestDriver > and ConsumerRecordFactory methods as one class to be used to write to Input > Topics and TestOutputTopic class which collects TopologyTestDriver reading > methods and provide typesafe read methods. > This is KIP: > [https://cwiki.apache.org/confluence/display/KAFKA/KIP-470%3A+TopologyTestDriver+test+input+and+output+usability+improvements] > > > More info and an example of how Stream test looks after using this classes: > [https://github.com/jukkakarvanen/kafka-streams-test-topics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
