[jira] [Commented] (KAFKA-8615) Change to track partition time breaks TimestampExtractor

2019-07-18 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/KAFKA-8615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888329#comment-16888329
 ] 

ASF GitHub Bot commented on KAFKA-8615:
---

guozhangwang commented on pull request #7054: KAFKA-8615: Change to track 
partition time breaks TimestampExtractor
URL: https://github.com/apache/kafka/pull/7054
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Change to track partition time breaks TimestampExtractor
> 
>
> Key: KAFKA-8615
> URL: https://issues.apache.org/jira/browse/KAFKA-8615
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 2.3.0
>Reporter: Bill Bejeck
>Assignee: Sophie Blee-Goldman
>Priority: Major
>
> From the users mailing list, *UPDATED* by Jonathan Santilli:
> {noformat}
> Am testing the new version 2.3 for Kafka Streams specifically. I have noticed 
> that now, the implementation of the method extract from the
> interface org.apache.kafka.streams.processor.TimestampExtractor:
> public class OwnTimeExtractor implements TimestampExtractor {
>     @Override
>     public long extract(final ConsumerRecord record, final 
> long previousTimestamp) {
>         // previousTimestamp is always == -1. For version 2.3
>     }
> }
> Previous version 2.2.1 was returning the correct value for the record 
> partition.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KAFKA-8615) Change to track partition time breaks TimestampExtractor

2019-07-08 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/KAFKA-8615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880820#comment-16880820
 ] 

ASF GitHub Bot commented on KAFKA-8615:
---

ableegoldman commented on pull request #7054: KAFKA-8615: Change to track 
partition time breaks TimestampExtractor
URL: https://github.com/apache/kafka/pull/7054
 
 
   We should be setting `headRecord` to null AFTER calling `updateHead()` since 
it calls `timestamp()` for the TimestampExtractor, which returns `UNKNOWN` if 
`head == null`
   
   Should be cherry-picked back to 2.3
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Change to track partition time breaks TimestampExtractor
> 
>
> Key: KAFKA-8615
> URL: https://issues.apache.org/jira/browse/KAFKA-8615
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 2.3.0
>Reporter: Bill Bejeck
>Assignee: Bill Bejeck
>Priority: Major
>
> From the users mailing list, *UPDATED* by Jonathan Santilli:
> {noformat}
> Am testing the new version 2.3 for Kafka Streams specifically. I have noticed 
> that now, the implementation of the method extract from the
> interface org.apache.kafka.streams.processor.TimestampExtractor:
> public class OwnTimeExtractor implements TimestampExtractor {
>     @Override
>     public long extract(final ConsumerRecord record, final 
> long previousTimestamp) {
>         // previousTimestamp is always == -1. For version 2.3
>     }
> }
> Previous version 2.2.1 was returning the correct value for the record 
> partition.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)