[jira] [Commented] (KAFKA-8857) Config describe should not return isReadOnly=false based on synonyms
[ https://issues.apache.org/jira/browse/KAFKA-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923178#comment-16923178 ] ASF GitHub Bot commented on KAFKA-8857: --- rajinisivaram commented on pull request #7278: KAFKA-8857; Don't check synonyms while determining if config is readOnly URL: https://github.com/apache/kafka/pull/7278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config describe should not return isReadOnly=false based on synonyms > > > Key: KAFKA-8857 > URL: https://issues.apache.org/jira/browse/KAFKA-8857 > Project: Kafka > Issue Type: Bug > Components: admin >Reporter: Rajini Sivaram >Assignee: Rajini Sivaram >Priority: Major > Fix For: 2.4.0 > > > At the moment, for configs like log.retention.hours which have multiple > synonyms (log.retention.ms, log.retention.minutes), we return > `isReadyOnly=false` in describeConfigs response for all the synomyms even > though only log.retention.ms can be updated dynamically. We should return > isReadOnly=false for log.retention.ms and isReadOnly=true for > log.retention.hours and log.retention.minutes to avoid confusion. Users can > still determine if there are updateable synonyms by looking at synonyms > returned in describeConfigs response. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (KAFKA-8857) Config describe should not return isReadOnly=false based on synonyms
[ https://issues.apache.org/jira/browse/KAFKA-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920833#comment-16920833 ] ASF GitHub Bot commented on KAFKA-8857: --- rajinisivaram commented on pull request #7278: KAFKA-8857; Don't check synonyms while determining if config is readOnly URL: https://github.com/apache/kafka/pull/7278 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config describe should not return isReadOnly=false based on synonyms > > > Key: KAFKA-8857 > URL: https://issues.apache.org/jira/browse/KAFKA-8857 > Project: Kafka > Issue Type: Bug > Components: admin >Reporter: Rajini Sivaram >Assignee: Rajini Sivaram >Priority: Major > Fix For: 2.4.0 > > > At the moment, for configs like log.retention.hours which have multiple > synonyms (log.retention.ms, log.retention.minutes), we return > `isReadyOnly=false` in describeConfigs response for all the synomyms even > though only log.retention.ms can be updated dynamically. We should return > isReadOnly=false for log.retention.ms and isReadOnly=true for > log.retention.hours and log.retention.minutes to avoid confusion. Users can > still determine if there are updateable synonyms by looking at synonyms > returned in describeConfigs response. -- This message was sent by Atlassian Jira (v8.3.2#803003)
