[jira] [Commented] (KAFKA-9150) DescribeGroup uses member assignment as metadata
[ https://issues.apache.org/jira/browse/KAFKA-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968921#comment-16968921 ] ASF GitHub Bot commented on KAFKA-9150: --- omkreddy commented on pull request #7658: KAFKA-9150; DescribeGroup uses member assignment as metadata URL: https://github.com/apache/kafka/pull/7658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DescribeGroup uses member assignment as metadata > > > Key: KAFKA-9150 > URL: https://issues.apache.org/jira/browse/KAFKA-9150 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: David Jacot >Priority: Blocker > Fix For: 2.4.0 > > > When we converted the DescribeGroup internally to rely on the generated > protocol in KAFKA-7922, we introduced a regression in the response handling. > Basically we serialize the member assignment as both the assignment and > metadata in the response: > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1326]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9150) DescribeGroup uses member assignment as metadata
[ https://issues.apache.org/jira/browse/KAFKA-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968519#comment-16968519 ] ASF GitHub Bot commented on KAFKA-9150: --- dajac commented on pull request #7658: KAFKA-9150; DescribeGroup uses member assignment as metadata URL: https://github.com/apache/kafka/pull/7658 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DescribeGroup uses member assignment as metadata > > > Key: KAFKA-9150 > URL: https://issues.apache.org/jira/browse/KAFKA-9150 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: David Jacot >Priority: Blocker > Fix For: 2.4.0 > > > When we converted the DescribeGroup internally to rely on the generated > protocol in KAFKA-7922, we introduced a regression in the response handling. > Basically we serialize the member assignment as both the assignment and > metadata in the response: > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1326]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9150) DescribeGroup uses member assignment as metadata
[ https://issues.apache.org/jira/browse/KAFKA-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968295#comment-16968295 ] Ismael Juma commented on KAFKA-9150: [~huxi_2b], it's OK if you submitted the PR at more or less the same time as [~dajac] assigned the issue to himself. The main thing is that we need a test with the fix asap. Do you have the cycles to do that? If not, maybe [~dajac] can take it over. > DescribeGroup uses member assignment as metadata > > > Key: KAFKA-9150 > URL: https://issues.apache.org/jira/browse/KAFKA-9150 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: David Jacot >Priority: Blocker > Fix For: 2.4.0 > > > When we converted the DescribeGroup internally to rely on the generated > protocol in KAFKA-7922, we introduced a regression in the response handling. > Basically we serialize the member assignment as both the assignment and > metadata in the response: > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1326]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9150) DescribeGroup uses member assignment as metadata
[ https://issues.apache.org/jira/browse/KAFKA-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968211#comment-16968211 ] huxihx commented on KAFKA-9150: --- Do not be aware that David Jacot already takes the jira. Closed the pull request. > DescribeGroup uses member assignment as metadata > > > Key: KAFKA-9150 > URL: https://issues.apache.org/jira/browse/KAFKA-9150 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: David Jacot >Priority: Blocker > Fix For: 2.4.0 > > > When we converted the DescribeGroup internally to rely on the generated > protocol in KAFKA-7922, we introduced a regression in the response handling. > Basically we serialize the member assignment as both the assignment and > metadata in the response: > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1326]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9150) DescribeGroup uses member assignment as metadata
[ https://issues.apache.org/jira/browse/KAFKA-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968208#comment-16968208 ] ASF GitHub Bot commented on KAFKA-9150: --- huxihx commented on pull request #7655: KAFKA-9150: DescribeGroup uses member assignment as metadata URL: https://github.com/apache/kafka/pull/7655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DescribeGroup uses member assignment as metadata > > > Key: KAFKA-9150 > URL: https://issues.apache.org/jira/browse/KAFKA-9150 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: David Jacot >Priority: Blocker > Fix For: 2.4.0 > > > When we converted the DescribeGroup internally to rely on the generated > protocol in KAFKA-7922, we introduced a regression in the response handling. > Basically we serialize the member assignment as both the assignment and > metadata in the response: > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1326]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9150) DescribeGroup uses member assignment as metadata
[ https://issues.apache.org/jira/browse/KAFKA-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968206#comment-16968206 ] ASF GitHub Bot commented on KAFKA-9150: --- huxihx commented on pull request #7655: KAFKA-9150: DescribeGroup uses member assignment as metadata URL: https://github.com/apache/kafka/pull/7655 https://issues.apache.org/jira/browse/KAFKA-9150 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > DescribeGroup uses member assignment as metadata > > > Key: KAFKA-9150 > URL: https://issues.apache.org/jira/browse/KAFKA-9150 > Project: Kafka > Issue Type: Bug >Reporter: Jason Gustafson >Assignee: David Jacot >Priority: Blocker > Fix For: 2.4.0 > > > When we converted the DescribeGroup internally to rely on the generated > protocol in KAFKA-7922, we introduced a regression in the response handling. > Basically we serialize the member assignment as both the assignment and > metadata in the response: > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1326]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
