[jira] [Commented] (KAFKA-9223) RebalanceSourceConnectorsIntegrationTest disrupting builds with System::exit

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979779#comment-16979779
 ] 

ASF GitHub Bot commented on KAFKA-9223:
---

rhauch commented on pull request #7734: KAFKA-9223: Mask exit procedure in 
rebalance integration test to prevent call to System::exit
URL: https://github.com/apache/kafka/pull/7734
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RebalanceSourceConnectorsIntegrationTest disrupting builds with System::exit
> 
>
> Key: KAFKA-9223
> URL: https://issues.apache.org/jira/browse/KAFKA-9223
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Affects Versions: 2.4.0, 2.3.2
>Reporter: Chris Egerton
>Assignee: Chris Egerton
>Priority: Major
>
> The RebalanceSourceConnectorsIntegrationTest causes builds to fail sometimes 
> by ungracefully shutting down its embedded Connect workers, which in turn 
> call System::exit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-9223) RebalanceSourceConnectorsIntegrationTest disrupting builds with System::exit

2019-11-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979738#comment-16979738
 ] 

ASF GitHub Bot commented on KAFKA-9223:
---

C0urante commented on pull request #7734: KAFKA-9223: Mask exit procedure in 
rebalance integration test to prevent call to System::exit
URL: https://github.com/apache/kafka/pull/7734
 
 
   We've been encountering some build instability that appears to be due to the 
`RebalanceSourceConnectorsIntegrationTest` class. Somehow, that test is causing 
an ungraceful shutdown of one or more of its embedded Connect workers, which 
then in turn invoke `Exit::exit`. The Connect integration test framework has 
support for overriding the behavior of `Exit::exit` to prevent it from calling 
`System::exit`; the changes here use that feature to help bring back build 
stability.
   Now, if the embedded Connect worker fails to shut down gracefully, a warning 
is logged but the test still passes and (more importantly), `System::exit` is 
never invoked.
   
   If approved, this fix should be backported through to 2.3, when the test was 
introduced.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> RebalanceSourceConnectorsIntegrationTest disrupting builds with System::exit
> 
>
> Key: KAFKA-9223
> URL: https://issues.apache.org/jira/browse/KAFKA-9223
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Affects Versions: 2.4.0, 2.3.2
>Reporter: Chris Egerton
>Assignee: Chris Egerton
>Priority: Major
>
> The RebalanceSourceConnectorsIntegrationTest causes builds to fail sometimes 
> by ungracefully shutting down its embedded Connect workers, which in turn 
> call System::exit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)