[jira] [Updated] (KAFKA-5906) Change metric.reporters configuration key to metrics.reporters to be consistent
[ https://issues.apache.org/jira/browse/KAFKA-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lu updated KAFKA-5906: Description: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but KafkaMetricsReporter is the actual interface to implement. There also seems to be a discrepancy with "MetricReporter" in the description as the class name is actually "MetricsReporter". https://github.com/apache/kafka/pull/3875 was: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but KafkaMetricsReporter is the actual interface to implement. There also seems to be a discrepancy with "MetricReporter" in the description as the class name is actually "MetricsReporter". https://github.com/apache/kafka/pull/3867 > Change metric.reporters configuration key to metrics.reporters to be > consistent > --- > > Key: KAFKA-5906 > URL: https://issues.apache.org/jira/browse/KAFKA-5906 > Project: Kafka > Issue Type: Improvement > Components: config, metrics >Reporter: Kevin Lu >Priority: Minor > Labels: usability > > The "metric.reporters" configuration key should be consistent with the actual > classes. Clients have a MetricsReporter.class while the broker has a > KafkaMetricsReporter.class. > We have seen quite a few people configure this field incorrectly by setting > it as "metrics.reporters". > The configuration key could be renamed to "metrics.reporters" to match the > classes, or the classes can be renamed to MetricReporter.class and > KafkaMetricReporter.class. > The broker configuration description for "metric.reporters" also mentions > MetricReporter, but KafkaMetricsReporter is the actual interface to > implement. > There also seems to be a discrepancy with "MetricReporter" in the description > as the class name is actually "MetricsReporter". > https://github.com/apache/kafka/pull/3875 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KAFKA-5906) Change metric.reporters configuration key to metrics.reporters to be consistent
[ https://issues.apache.org/jira/browse/KAFKA-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lu updated KAFKA-5906: Description: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but KafkaMetricsReporter is the actual interface to implement. There also seems to be a discrepancy with "MetricReporter" in the description as the class name is actually "MetricsReporter". https://github.com/apache/kafka/pull/3867 was: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but the actual interface to implement is KafkaMetricsReporter. There also seems to be a discrepancy with "MetricReporter" in the description as the class name is actually "MetricsReporter". https://github.com/apache/kafka/pull/3867 > Change metric.reporters configuration key to metrics.reporters to be > consistent > --- > > Key: KAFKA-5906 > URL: https://issues.apache.org/jira/browse/KAFKA-5906 > Project: Kafka > Issue Type: Improvement > Components: config, metrics >Reporter: Kevin Lu >Priority: Minor > Labels: usability > > The "metric.reporters" configuration key should be consistent with the actual > classes. Clients have a MetricsReporter.class while the broker has a > KafkaMetricsReporter.class. > We have seen quite a few people configure this field incorrectly by setting > it as "metrics.reporters". > The configuration key could be renamed to "metrics.reporters" to match the > classes, or the classes can be renamed to MetricReporter.class and > KafkaMetricReporter.class. > The broker configuration description for "metric.reporters" also mentions > MetricReporter, but KafkaMetricsReporter is the actual interface to > implement. > There also seems to be a discrepancy with "MetricReporter" in the description > as the class name is actually "MetricsReporter". > https://github.com/apache/kafka/pull/3867 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KAFKA-5906) Change metric.reporters configuration key to metrics.reporters to be consistent
[ https://issues.apache.org/jira/browse/KAFKA-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lu updated KAFKA-5906: Description: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but the actual interface to implement is KafkaMetricsReporter. There also seems to be a discrepancy with "MetricReporter" in the description as the class name is actually "MetricsReporter". https://github.com/apache/kafka/pull/3867 was: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but the actual interface to implement is KafkaMetricsReporter. > Change metric.reporters configuration key to metrics.reporters to be > consistent > --- > > Key: KAFKA-5906 > URL: https://issues.apache.org/jira/browse/KAFKA-5906 > Project: Kafka > Issue Type: Improvement > Components: config, metrics >Reporter: Kevin Lu >Priority: Minor > Labels: usability > > The "metric.reporters" configuration key should be consistent with the actual > classes. Clients have a MetricsReporter.class while the broker has a > KafkaMetricsReporter.class. > We have seen quite a few people configure this field incorrectly by setting > it as "metrics.reporters". > The configuration key could be renamed to "metrics.reporters" to match the > classes, or the classes can be renamed to MetricReporter.class and > KafkaMetricReporter.class. > The broker configuration description for "metric.reporters" also mentions > MetricReporter, but the actual interface to implement is > KafkaMetricsReporter. > There also seems to be a discrepancy with "MetricReporter" in the description > as the class name is actually "MetricsReporter". > https://github.com/apache/kafka/pull/3867 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KAFKA-5906) Change metric.reporters configuration key to metrics.reporters to be consistent
[ https://issues.apache.org/jira/browse/KAFKA-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lu updated KAFKA-5906: Description: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. The broker configuration description for "metric.reporters" also mentions MetricReporter, but the actual interface to implement is KafkaMetricsReporter. was: The "metric.reporters" configuration key should be consistent with the actual classes. Clients have a MetricsReporter.class while the broker has a KafkaMetricsReporter.class. We have seen quite a few people configure this field incorrectly by setting it as "metrics.reporters". The configuration key could be renamed to "metrics.reporters" to match the classes, or the classes can be renamed to MetricReporter.class and KafkaMetricReporter.class. > Change metric.reporters configuration key to metrics.reporters to be > consistent > --- > > Key: KAFKA-5906 > URL: https://issues.apache.org/jira/browse/KAFKA-5906 > Project: Kafka > Issue Type: Improvement > Components: config, metrics >Reporter: Kevin Lu >Priority: Minor > Labels: usability > > The "metric.reporters" configuration key should be consistent with the actual > classes. Clients have a MetricsReporter.class while the broker has a > KafkaMetricsReporter.class. > We have seen quite a few people configure this field incorrectly by setting > it as "metrics.reporters". > The configuration key could be renamed to "metrics.reporters" to match the > classes, or the classes can be renamed to MetricReporter.class and > KafkaMetricReporter.class. > The broker configuration description for "metric.reporters" also mentions > MetricReporter, but the actual interface to implement is > KafkaMetricsReporter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
