Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

showuon commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1999010980

   Sorry that I missed the ping. Thanks Satish for helping review. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

satishd merged PR #15490:
URL: https://github.com/apache/kafka/pull/15490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

satishd commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1998903881

   Failing tests are unrelated to this change, merging it to 3.6 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

divijvaidya commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1985969718

   @showuon can you please take a look at this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

divijvaidya commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1985969187

   The failing tests are known to be flaky for 3.6 branch, e,g, 
https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=3.6&search.timeZoneId=Europe%2FBerlin&tests.container=kafka.server.KRaftClusterTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

gaurav-narula commented on code in PR #15490:
URL: https://github.com/apache/kafka/pull/15490#discussion_r1516423400


##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -154,6 +159,25 @@ class KafkaServerTest extends QuorumTestHarness {
 server.shutdown()
   }
 
+  @Test
+  def testOfflineDirectoryOnMetadataCheckpointIOError(): Unit = {
+val props = TestUtils.createBrokerConfigs(1, zkConnect).head
+val kafkaConfig = KafkaConfig.fromProps(props)
+val server: KafkaServer = TestUtils.createServer(kafkaConfig, new 
MockTime, None, startup = false)
+
+val spyValue: BrokerMetadataCheckpoint = 
spy(server.brokerMetadataCheckpoints.head._2)
+doThrow(new IOException()).when(spyValue).write(any())
+server.brokerMetadataCheckpoints = 
server.brokerMetadataCheckpoints.updated(server.brokerMetadataCheckpoints.head._1,
 spyValue)
+
+try {
+  server.startup()
+  
assertTrue(server.logDirFailureChannel.hasOfflineLogDir(kafkaConfig.logDirs.head),

Review Comment:
   ~Could this flake? Might be worth enclosing in `TestUtils.waitUntilTrue` 
perhaps?~
   
   nvm, it's invoked in `startup()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

[via GitHub]

gaurav-narula commented on code in PR #15490:
URL: https://github.com/apache/kafka/pull/15490#discussion_r1516423400


##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -154,6 +159,25 @@ class KafkaServerTest extends QuorumTestHarness {
 server.shutdown()
   }
 
+  @Test
+  def testOfflineDirectoryOnMetadataCheckpointIOError(): Unit = {
+val props = TestUtils.createBrokerConfigs(1, zkConnect).head
+val kafkaConfig = KafkaConfig.fromProps(props)
+val server: KafkaServer = TestUtils.createServer(kafkaConfig, new 
MockTime, None, startup = false)
+
+val spyValue: BrokerMetadataCheckpoint = 
spy(server.brokerMetadataCheckpoints.head._2)
+doThrow(new IOException()).when(spyValue).write(any())
+server.brokerMetadataCheckpoints = 
server.brokerMetadataCheckpoints.updated(server.brokerMetadataCheckpoints.head._1,
 spyValue)
+
+try {
+  server.startup()
+  
assertTrue(server.logDirFailureChannel.hasOfflineLogDir(kafkaConfig.logDirs.head),

Review Comment:
   Could this flake? Might be worth enclosing in `TestUtils.waitUntilTrue` 
perhaps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org