Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-06 Thread via GitHub


omkreddy merged PR #15651:
URL: https://github.com/apache/kafka/pull/15651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-05 Thread via GitHub


omkreddy commented on code in PR #15651:
URL: https://github.com/apache/kafka/pull/15651#discussion_r1554531283


##
release.py:
##
@@ -348,6 +348,9 @@ def command_release_announcement_email():
 
 
 
+An overview of the release and its notable changes can be found in the
+release blog post: 

Review Comment:
   Thanks for the review,. updated the PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-05 Thread via GitHub


chia7712 commented on code in PR #15651:
URL: https://github.com/apache/kafka/pull/15651#discussion_r1554150631


##
release.py:
##
@@ -348,6 +348,9 @@ def command_release_announcement_email():
 
 
 
+An overview of the release and its notable changes can be found in the
+release blog post: 

Review Comment:
   Can we generate the link automatically if the link formate is like 
`https://kafka.apache.org/blog#apache_kafka_362_release_announcement`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org